Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use correct mean and standard deviation norm values in image tutorials #50240

Merged
merged 2 commits into from
Mar 6, 2025
Merged

use correct mean and standard deviation norm values in image tutorials #50240

merged 2 commits into from
Mar 6, 2025

Conversation

crypdick
Copy link
Contributor

@crypdick crypdick commented Feb 5, 2025

Why are these changes needed?

Updates docs to use correct normalization values in image datasets.

Related issue number

Closes #50239

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@crypdick crypdick linked an issue Feb 5, 2025 that may be closed by this pull request
[Docs] Tutorials should use correct normalization values for image datasets #50239
Closed
@crypdick
use correct mean and standard deviation norm values in image tutorials
75868be 
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
@crypdick crypdick force-pushed the 50239-docs-tutorials-should-use-correct-normalization-values-for-image-datasets branch from 2ca6a58 to 75868be Compare February 5, 2025 19:35
@crypdick
make linter happy
6727057 
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
angelinalg
angelinalg approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@matthewdeng matthewdeng enabled auto-merge (squash) March 6, 2025 18:01
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Mar 6, 2025
@matthewdeng matthewdeng merged commit f6c800d into master Mar 6, 2025
7 checks passed
@matthewdeng matthewdeng deleted the 50239-docs-tutorials-should-use-correct-normalization-values-for-image-datasets branch March 6, 2025 20:05
elimelt pushed a commit to elimelt/ray that referenced this pull request Mar 9, 2025
@crypdick @elimelt
[train] use correct mean and standard deviation norm values in image …
7d27d9d 
…tutorials (ray-project#50240)

Updates docs to use correct normalization values in image datasets.

---------

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

@angelinalg angelinalg angelinalg approved these changes

@hongpeng-guo hongpeng-guo Awaiting requested review from hongpeng-guo hongpeng-guo is a code owner

@justinvyu justinvyu Awaiting requested review from justinvyu justinvyu is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Tutorials should use correct normalization values for image datasets
3 participants
@crypdick @matthewdeng @angelinalg