Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various enhancements to the Gradio Ray Serve tutorial #50276

Merged
merged 7 commits into from
Mar 6, 2025

Conversation

crypdick
Copy link
Contributor

@crypdick crypdick commented Feb 6, 2025

Why are these changes needed?

  • adds missing pip requirements
  • improves the overall narrative flow of the tutorial
  • clarifies that there are 2 separate examples within the same page
  • clarifies the difference between the two methods

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

* adds missing pip requirements
* improves the overall narrative flow of the tutorial
* clarifies that there are 2 separate examples within the same page
* clarifies the difference between the two methods

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
@edoakes
Copy link
Collaborator

edoakes commented Feb 6, 2025

@zcin to review

@jcotant1 jcotant1 added serve Ray Serve Related Issue docs An issue or change related to documentation labels Feb 6, 2025
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some style nits.

@pcmoritz
Copy link
Contributor

pcmoritz commented Mar 5, 2025

Should we fix this up and merge it before it gets stale? @crypdick @zcin

Copy link
Contributor

@zcin zcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crypdick and others added 6 commits March 5, 2025 15:29
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com>
Co-authored-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com>
@pcmoritz pcmoritz enabled auto-merge (squash) March 6, 2025 05:18
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Mar 6, 2025
@pcmoritz pcmoritz merged commit b1e725e into master Mar 6, 2025
7 checks passed
@pcmoritz pcmoritz deleted the fix-gradio-rayserve branch March 6, 2025 05:47
abrarsheikh pushed a commit that referenced this pull request Mar 8, 2025
## Why are these changes needed?

* adds missing pip requirements
* improves the overall narrative flow of the tutorial
* clarifies that there are 2 separate examples within the same page
* clarifies the difference between the two methods

## Related issue number

N/A

## Checks

- [X] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
elimelt pushed a commit to elimelt/ray that referenced this pull request Mar 9, 2025
…ect#50276)

## Why are these changes needed?

* adds missing pip requirements
* improves the overall narrative flow of the tutorial
* clarifies that there are 2 separate examples within the same page
* clarifies the difference between the two methods

## Related issue number

N/A

## Checks

- [X] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Cindy Zhang <cindyzyx9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation go add ONLY when ready to merge, run all tests serve Ray Serve Related Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants