Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to Tune Pytorch CIFAR tutorial #50316

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

crypdick
Copy link
Contributor

@crypdick crypdick commented Feb 7, 2025

Why are these changes needed?

  • added missing pip requirements
  • surpressed verbose outputs with a few hide-cell tags
  • improved overall narrative flow
  • factored out dataset creation code to make things tidy
  • added net.train() net.eval() toggles
  • added weight decay, as a treat
  • consistent use of nn.DataParallel
  • deduplicated discussion about search spaces
  • fixed the smoke tests

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

* added missing pip requirements
* surpressed verbose outputs with a few `hide-cell` tags
* improved overall narrative flow
* factored out dataset creation code to make things tidy
* added net.train() net.eval() toggles
* added weight decay, as a treat
* consistent use of nn.DataParallel
* deduplicated discussion about search spaces
* fixed the smoke tests

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com>
@pcmoritz pcmoritz enabled auto-merge (squash) March 6, 2025 00:43
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Mar 6, 2025
@pcmoritz pcmoritz merged commit 59ded6a into master Mar 6, 2025
7 checks passed
@pcmoritz pcmoritz deleted the fix/tune-pytorch-cifar branch March 6, 2025 01:41
abrarsheikh pushed a commit that referenced this pull request Mar 8, 2025
## Why are these changes needed?

* added missing pip requirements
* surpressed verbose outputs with a few `hide-cell` tags
* improved overall narrative flow
* factored out dataset creation code to make things tidy
* added net.train() net.eval() toggles
* added weight decay, as a treat
* consistent use of nn.DataParallel
* deduplicated discussion about search spaces
* fixed the smoke tests

## Related issue number

N/A
## Checks

- [X] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com>
Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
elimelt pushed a commit to elimelt/ray that referenced this pull request Mar 9, 2025
…t#50316)

## Why are these changes needed?

* added missing pip requirements
* surpressed verbose outputs with a few `hide-cell` tags
* improved overall narrative flow
* factored out dataset creation code to make things tidy
* added net.train() net.eval() toggles
* added weight decay, as a treat
* consistent use of nn.DataParallel
* deduplicated discussion about search spaces
* fixed the smoke tests

## Related issue number

N/A
## Checks

- [X] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants