Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][autoscaler] fix indentation of use_podman #50653

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[core][autoscaler] fix indentation of use_podman #50653

merged 1 commit into from
Feb 18, 2025

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Feb 17, 2025 •
edited
Loading

in ray-schema.json

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@davidxia
[core][autoscaler] fix indentation of use_podman
374005c 
in ray-schema.json

Signed-off-by: David Xia <david@davidxia.com>
@davidxia davidxia marked this pull request as ready for review February 17, 2025 12:09
@davidxia davidxia requested review from hongchaodeng and a team as code owners February 17, 2025 12:09
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Feb 18, 2025
@edoakes edoakes enabled auto-merge (squash) February 18, 2025 13:38
@edoakes edoakes merged commit a8e217d into ray-project:master Feb 18, 2025
7 checks passed
400Ping pushed a commit to 400Ping/ray that referenced this pull request Feb 20, 2025
@davidxia @400Ping
[core][autoscaler] fix indentation of use_podman (ray-project#50653)
e4e435c 
in ray-schema.json

Signed-off-by: David Xia <david@davidxia.com>
Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
israbbani pushed a commit that referenced this pull request Feb 25, 2025
@davidxia @israbbani
[core][autoscaler] fix indentation of use_podman (#50653)
372050f 
in ray-schema.json

Signed-off-by: David Xia <david@davidxia.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@davidxia @xsuler
[core][autoscaler] fix indentation of use_podman (ray-project#50653)
2d45e27 
in ray-schema.json

Signed-off-by: David Xia <david@davidxia.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@davidxia @xsuler
[core][autoscaler] fix indentation of use_podman (ray-project#50653)
27907cb 
in ray-schema.json

Signed-off-by: David Xia <david@davidxia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidxia @edoakes