Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Update jemalloc profiling doc #51031

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Mar 3, 2025

Why are these changes needed?

I find the documentation is not easy to follow. I improved it by adding more details and providing the expected output for certain steps to avoid confusion.

image

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
@kevin85421 kevin85421 marked this pull request as ready for review March 3, 2025 16:37
@kevin85421 kevin85421 requested a review from a team as a code owner March 3, 2025 16:37
Copy link
Contributor

@dayshah dayshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice lgtm

@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Mar 3, 2025
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
./configure --enable-prof --enable-prof-libunwind
make
make install
sudo make install
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-03-02 at 11 59 10 PM

@kevin85421 kevin85421 requested a review from edoakes March 5, 2025 18:50
Copy link
Collaborator

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@edoakes edoakes merged commit bccc1df into ray-project:master Mar 5, 2025
5 checks passed
abrarsheikh pushed a commit that referenced this pull request Mar 8, 2025
I find the documentation is not easy to follow. I improved it by adding
more details and providing the expected output for certain steps to
avoid confusion.

<img width="1176" alt="image"
src="https://github.com/user-attachments/assets/df24e88c-d2de-412e-ae0c-573dfffc4c3c"
/>

---------

Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
elimelt pushed a commit to elimelt/ray that referenced this pull request Mar 9, 2025
I find the documentation is not easy to follow. I improved it by adding
more details and providing the expected output for certain steps to
avoid confusion.

<img width="1176" alt="image"
src="https://github.com/user-attachments/assets/df24e88c-d2de-412e-ae0c-573dfffc4c3c"
/>

---------

Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants