-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Update jemalloc profiling doc #51031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayshah
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice lgtm
kevin85421
commented
Mar 3, 2025
./configure --enable-prof --enable-prof-libunwind | ||
make | ||
make install | ||
sudo make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edoakes
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
abrarsheikh
pushed a commit
that referenced
this pull request
Mar 8, 2025
I find the documentation is not easy to follow. I improved it by adding more details and providing the expected output for certain steps to avoid confusion. <img width="1176" alt="image" src="https://github.com/user-attachments/assets/df24e88c-d2de-412e-ae0c-573dfffc4c3c" /> --------- Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
elimelt
pushed a commit
to elimelt/ray
that referenced
this pull request
Mar 9, 2025
I find the documentation is not easy to follow. I improved it by adding more details and providing the expected output for certain steps to avoid confusion. <img width="1176" alt="image" src="https://github.com/user-attachments/assets/df24e88c-d2de-412e-ae0c-573dfffc4c3c" /> --------- Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I find the documentation is not easy to follow. I improved it by adding more details and providing the expected output for certain steps to avoid confusion.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.