Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][2/N] Remove redis_max_memory from Ray core #51059

Merged
merged 4 commits into from
Mar 5, 2025
Merged

[core][2/N] Remove redis_max_memory from Ray core #51059

merged 4 commits into from
Mar 5, 2025

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Mar 4, 2025 •
edited
Loading

Why are these changes needed?

This is a follow up of #51023.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kevin85421
remove redis_max_memory
4b58e7c 
Signed-off-by: kaihsun <kaihsun@anyscale.com>
@kevin85421
remove redis_max_memory
c6ed649 
Signed-off-by: kaihsun <kaihsun@anyscale.com>
@kevin85421
update
9320f5f 
Signed-off-by: kaihsun <kaihsun@anyscale.com>
@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Mar 5, 2025
@kevin85421 kevin85421 marked this pull request as ready for review March 5, 2025 18:49
@edoakes edoakes merged commit c1e4372 into ray-project:master Mar 5, 2025
5 checks passed
abrarsheikh pushed a commit that referenced this pull request Mar 8, 2025
@kevin85421 @abrarsheikh
[core][2/N] Remove redis_max_memory from Ray core (#51059)
f402c3d 
This is a follow up of #51023.

---------

Signed-off-by: kaihsun <kaihsun@anyscale.com>
Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
elimelt pushed a commit to elimelt/ray that referenced this pull request Mar 9, 2025
@kevin85421 @elimelt
[core][2/N] Remove redis_max_memory from Ray core (ray-project#51059)
dcfd1b8 
This is a follow up of ray-project#51023.

---------

Signed-off-by: kaihsun <kaihsun@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

Assignees

@edoakes edoakes

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin85421 @edoakes