Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Checkin opentelemetry C++ sdk dependency #51077

Merged

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Mar 4, 2025

opencensus has been archived for ~2 years, we should upgrade to opentelemetry which is the somewhat an "improved" and maintained version.

Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny added the go add ONLY when ready to merge, run all tests label Mar 4, 2025
@dentiny dentiny requested review from jjyao and edoakes March 4, 2025 23:15
@dentiny dentiny requested a review from aslonnie March 4, 2025 23:18
@dentiny dentiny assigned jjyao, edoakes and aslonnie and unassigned jjyao and edoakes Mar 4, 2025
@edoakes
Copy link
Collaborator

edoakes commented Mar 4, 2025

Looks fine, but let's check it in with the code that uses it?

Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but let's check it in with the code that uses it?

+1, maybe use it at least for once? otherwise it is hard to tell if the import works.

Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny
Copy link
Contributor Author

dentiny commented Mar 5, 2025

Looks fine, but let's check it in with the code that uses it?

I thought about that, the most ideal way is to have a basic replacement implementation for metrics class that we have, but checking the codebase there're much work to do.

One concern is the compatibility between opencensus vs opentelemetry, like the default endpoint.

But I think your argument makes sense; I add a simple "test script" to show dependency checkin has no problem.

@dentiny dentiny requested a review from aslonnie March 5, 2025 00:28
Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny requested a review from aslonnie March 5, 2025 01:18
Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny force-pushed the hjiang/checkin-opentelemetry-sdk branch from adc90cc to b9da27f Compare March 5, 2025 01:27
@MengjinYan
Copy link
Collaborator

Thanks for taking this on! Just to confirm, this is just to add the open telemetry dependency and there will be followup PRs to fix the breaking changes (https://opentelemetry.io/docs/specs/otel/compatibility/opencensus/) between the OpenCensus and OPTL, is that correct?

@dentiny
Copy link
Contributor Author

dentiny commented Mar 5, 2025

Thanks for taking this on! Just to confirm, this is just to add the open telemetry dependency and there will be followup PRs to fix the breaking changes (https://opentelemetry.io/docs/specs/otel/compatibility/opencensus/) between the OpenCensus and OPTL, is that correct?

Yes, my plan is to implement a compatible metrics class, which is a counterpart for existing class, later on migrate metrics usage one by one.

@MengjinYan
Copy link
Collaborator

Thanks for taking this on! Just to confirm, this is just to add the open telemetry dependency and there will be followup PRs to fix the breaking changes (https://opentelemetry.io/docs/specs/otel/compatibility/opencensus/) between the OpenCensus and OPTL, is that correct?

Yes, my plan is to implement a compatible metrics class, which is a counterpart for existing class, later on migrate metrics usage one by one.

I'm wondering other than the metrics classes, whether the metrics collectors and exporters needs to be updated as well.

@edoakes edoakes merged commit b53dc04 into ray-project:master Mar 5, 2025
5 checks passed
abrarsheikh pushed a commit that referenced this pull request Mar 8, 2025
[opencensus](https://github.com/census-instrumentation/opencensus-cpp)
has been archived for ~2 years, we should upgrade to opentelemetry which
is the somewhat an "improved" and maintained version.

---------

Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
elimelt pushed a commit to elimelt/ray that referenced this pull request Mar 9, 2025
[opencensus](https://github.com/census-instrumentation/opencensus-cpp)
has been archived for ~2 years, we should upgrade to opentelemetry which
is the somewhat an "improved" and maintained version.

---------

Signed-off-by: dentiny <dentinyhao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants