[core][cgraph] Fix doc test cgraph_overlap #51139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
dayshah
approved these changes
Mar 6, 2025
dayshah
reviewed
Mar 6, 2025
| # Now, we force kill the actors if not yet. | ||
| for actor in outer.worker_task_refs: | ||
| logger.info(f"Killing actor: {actor}") | ||
| ray.kill(actor) |
There was a problem hiding this comment.
what if they were already killed before, should we be double killing, should we check if they were killed before?
There was a problem hiding this comment.
I think there is no effect if the actor is already killed:
ray/src/ray/gcs/gcs_server/gcs_actor_manager.cc
Line 1745 in e56a4cd
Also did a quick test, there is no issue with a double kill.
elimelt
pushed a commit
to elimelt/ray
that referenced
this pull request
Mar 9, 2025
Explicitly tear down the compiled graph and kill the actors rather than relying on GC. Also previously in Compiled Graph, actor is killed only when the actor task does not finish within timeout. This PR fixes it by always killing the actor when kill_actors=True. Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Explicitly tear down the compiled graph and kill the actors rather than relying on GC.
Also previously in Compiled Graph, actor is killed only when the actor task does not finish within timeout. This PR fixes it by always killing the actor when kill_actors=True.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.