Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Fix bad mock import #51170

Merged
merged 2 commits into from
Mar 7, 2025
Merged

[serve] Fix bad mock import #51170

merged 2 commits into from
Mar 7, 2025

Conversation

edoakes
Copy link
Collaborator

@edoakes edoakes commented Mar 7, 2025

Why are these changes needed?

Somehow a bad import snuck in...

Related issue number

Closes #49634
Closes #49632
Closes #49638
Closes #49642

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

edoakes added 2 commits March 7, 2025 11:55
@edoakes
fix
5cf6286 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
0ddb8e9 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Mar 7, 2025
@edoakes edoakes requested review from abrarsheikh and zcin March 7, 2025 17:57
@edoakes edoakes enabled auto-merge (squash) March 7, 2025 17:58
@edoakes edoakes merged commit 87f47e2 into ray-project:master Mar 7, 2025
6 checks passed
elimelt pushed a commit to elimelt/ray that referenced this pull request Mar 9, 2025
@edoakes @elimelt
[serve] Fix bad mock import (ray-project#51170)
3653650 
Somehow a bad import snuck in...

## Related issue number

Closes ray-project#49634
Closes ray-project#49632
Closes ray-project#49638
Closes ray-project#49642

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrarsheikh abrarsheikh abrarsheikh approved these changes

@zcin zcin zcin approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
3 participants
@edoakes @abrarsheikh @zcin