Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rllib dependency from core tests #51171

Merged
merged 23 commits into from
Mar 7, 2025
Merged

Remove rllib dependency from core tests #51171

merged 23 commits into from
Mar 7, 2025

Conversation

edoakes
Copy link
Collaborator

@edoakes edoakes commented Mar 7, 2025 •
edited
Loading

Why are these changes needed?

More work towards breaking the core -> libraries dependencies.

  • test_output.py: changed to use ray core API instead.
  • test_client_library_integration.py: moved to a test inside rllib directory.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

edoakes added 17 commits February 14, 2025 11:23
@edoakes
fix
7e77851 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
wip
2ad7479 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
Merge branch 'master' of https://github.com/ray-project/ray into eoak…
e1d4dc4 
…es/mask-data-dir
@edoakes
wip
31ee1cc 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
1840c69 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
6666527 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
4e19350 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
Merge branch 'master' of https://github.com/ray-project/ray into eoak…
9f6d678 
…es/mask-rllib-dir
@edoakes
fix
ff685e6 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
2aa233d 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
6cc849a 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
WIP
9db6774 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
2f61110 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
48e8a91 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
comment
32617de 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
1f5f8fd 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
887e4fd 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested review from sven1977, simonsays1980 and a team as code owners March 7, 2025 18:10
edoakes added 3 commits March 7, 2025 12:10
@edoakes
fix
56cce89 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
80c4b8c 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
47338a1 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
edoakes
edoakes commented Mar 7, 2025
View reviewed changes
python/ray/tests/test_client_library_integration.py


@pytest.mark.skip(reason="KV store is not working properly.")
def test_rllib_integration(ray_start_regular):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved this to rllib test file

edoakes
edoakes commented Mar 7, 2025
View reviewed changes
python/ray/tests/test_client_library_integration.py
trainer.train()


def test_rllib_integration_tune(ray_start_regular):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tune already has tests for ray client usage

@edoakes edoakes changed the title [WIP] Remove rllib tests from core tests dir Remove rllib dependency from core tests dir Mar 7, 2025
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Mar 7, 2025
@edoakes edoakes changed the title Remove rllib dependency from core tests dir Remove rllib dependency from core tests Mar 7, 2025
simonsays1980
simonsays1980 approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @edoakes !

@richardliaw richardliaw added the data Ray Data-related issues label Mar 7, 2025
@edoakes edoakes removed the data Ray Data-related issues label Mar 7, 2025
@edoakes
fix
1809291 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes enabled auto-merge (squash) March 7, 2025 19:09
@edoakes
fix
1d7d3af 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@github-actions github-actions bot disabled auto-merge March 7, 2025 20:44
@edoakes edoakes merged commit 6752e4d into ray-project:master Mar 7, 2025
5 checks passed
elimelt pushed a commit to elimelt/ray that referenced this pull request Mar 9, 2025
@edoakes @elimelt
Remove rllib dependency from core tests (ray-project#51171)
5c574d9 
More work towards breaking the core -> libraries dependencies.

- `test_output.py`: changed to use ray core API instead.
- `test_client_library_integration.py`: moved to a test inside rllib
directory.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@aslonnie aslonnie aslonnie approved these changes

@sven1977 sven1977 Awaiting requested review from sven1977 sven1977 is a code owner

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edoakes @simonsays1980 @aslonnie @richardliaw