Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][cgraph][doc]Fix cgraphs gpu docs code again #51208

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

dayshah
Copy link
Contributor

@dayshah dayshah commented Mar 10, 2025

Why are these changes needed?

Pre-merge passed on the last fix just because the tests were already marked flaky, and not all of them were running on pre-merge because of flakiness. Tests already marked flaky only run on post-merge.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: dayshah <dhyey2019@gmail.com>
@dayshah dayshah changed the title [coreFix cgraphs gpu docs code again [core][cgraph][doc]Fix cgraphs gpu docs code again Mar 10, 2025
dayshah added 2 commits March 9, 2025 22:51
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
@dayshah
Copy link
Contributor Author

dayshah commented Mar 10, 2025

Verified by actually running on a multi-gpu machine, wish we could actually run select flaky tests in ci optionally on pre-merge though when fixing.

@dayshah dayshah marked this pull request as ready for review March 10, 2025 05:58
@dayshah dayshah requested a review from a team as a code owner March 10, 2025 05:58
@dayshah dayshah added the go add ONLY when ready to merge, run all tests label Mar 10, 2025
@dayshah dayshah requested a review from ruisearch42 March 10, 2025 05:58
@edoakes edoakes merged commit 60f081d into ray-project:master Mar 10, 2025
6 checks passed
@dayshah dayshah deleted the fix-cgraphs-docs-again branch March 10, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants