Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test][KubeRay] Add doctest for RayCluster Quickstart doc #51249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented Mar 11, 2025

Why are these changes needed?

Real implementation for #50988. Add doc test for the "RayCluster Quickstart" doc.

doc link: https://anyscale-ray--51249.com.readthedocs.build/en/51249/cluster/kubernetes/getting-started/raycluster-quick-start.html

Related issue number

ray-project/kuberay#3157

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness added the go add ONLY when ready to merge, run all tests label Mar 11, 2025
@MortalHappiness MortalHappiness force-pushed the feature/kuberay-doctest-raycluster-quickstart branch 3 times, most recently from a4820f9 to c077002 Compare March 11, 2025 15:24
@MortalHappiness MortalHappiness marked this pull request as ready for review March 11, 2025 22:48
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the feature/kuberay-doctest-raycluster-quickstart branch from 30457c1 to 099e067 Compare March 11, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants