Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Large objects release test #51625

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dayshah
Copy link
Contributor

@dayshah dayshah commented Mar 22, 2025

Why are these changes needed?

To have an ongoing benchmark that tests 4GB object broadcasts to and ingests from 9 other nodes.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: dayshah <dhyey2019@gmail.com>
@dayshah dayshah marked this pull request as draft March 22, 2025 22:34
dayshah added 4 commits March 22, 2025 16:43
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
@dayshah dayshah added the go add ONLY when ready to merge, run all tests label Mar 24, 2025
@dayshah dayshah marked this pull request as ready for review March 24, 2025 06:52
Signed-off-by: dayshah <dhyey2019@gmail.com>
Copy link
Contributor

@dentiny dentiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm also curious, when we checkin new release benchmarks, should we also attach the benchmark results somewhere (i.e. a file in the codebase so we could refer to)?

@dayshah
Copy link
Contributor Author

dayshah commented Mar 25, 2025

Thank you! I'm also curious, when we checkin new release benchmarks, should we also attach the benchmark results somewhere (i.e. a file in the codebase so we could refer to)?

it'll automatically get made like this https://github.com/ray-project/ray/blob/master/release/perf_metrics/benchmarks/many_actors.json

https://github.com/ray-project/ray/pull/51427/files

during release process

@edoakes
Copy link
Collaborator

edoakes commented Mar 25, 2025

Still good practice to include results from a manual run before checking in, let's do that in all such PRs (clear paper trail when looking at git history).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants