-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Large objects release test #51625
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'm also curious, when we checkin new release benchmarks, should we also attach the benchmark results somewhere (i.e. a file in the codebase so we could refer to)?
it'll automatically get made like this https://github.com/ray-project/ray/blob/master/release/perf_metrics/benchmarks/many_actors.json https://github.com/ray-project/ray/pull/51427/files during release process |
Still good practice to include results from a manual run before checking in, let's do that in all such PRs (clear paper trail when looking at git history). |
Why are these changes needed?
To have an ongoing benchmark that tests 4GB object broadcasts to and ingests from 9 other nodes.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.