[release] Fix perf metrics compare #51655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <dentinyhao@gmail.com>
aslonnie
approved these changes
Mar 24, 2025
@aslonnie what script you are using to generate the diff now? |
discussed offline. this script is mainly for manual ad-hoc use today. |
angelinalg
pushed a commit
to angelinalg/ray
that referenced
this pull request
Mar 26, 2025
When doing release benchmark comparison, I found the script is performing comparison on **full filepaths** rather than **release result filenames**. Signed-off-by: dentiny <dentinyhao@gmail.com>
dhakshin32
pushed a commit
to dhakshin32/ray
that referenced
this pull request
Mar 27, 2025
When doing release benchmark comparison, I found the script is performing comparison on **full filepaths** rather than **release result filenames**. Signed-off-by: dentiny <dentinyhao@gmail.com> Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing release benchmark comparison, I found the script is performing comparison on full filepaths rather than release result filenames.
In details, this is the command I executed
And here's the benchmark files within
As you could tell, the result filenames (items) are exactly the same, but the script fails to recognize it.
In this PR, I tried to map from filenames / item names to its full filepaths.