[Core] Ensure Ray vendored libraries only be visible and used by Ray internal

[Bye-legumes]

Why are these changes needed?

fix issue #52763

Related issue number

Checks

• I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
• I've run scripts/format.sh to lint the changes in this PR.
• I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've added any new APIs to the API Reference. For example, if I added a
    method in Tune, I've added it in doc/source/tune/api/ under the
    corresponding .rst file.
• I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
• Testing Strategy
  • Unit tests
  • Release tests
  • This PR is not tested :(

[jjyao]

Does this work? For files inside psutil, if they import each other, will they import the public one instead of the thirdparty_files one?

[Bye-legumes]

we are testing and it should work, let me check. I just remove psutil as there are too many places that use this. If this work we can check if we should refactor all or some libs that into internal, i.e. numpy, traceback,, time. Or we just modify the libs that tends to easily have issues? What do you think?

[jjyao]

Yea, I'm not sure if that works. The way I'm aware is checking in the source code directly and change the import path of all the files. Something like https://github.com/pradyunsg/vendoring does.

[jjyao]

@Bye-legumes does this approach work?

[jjyao]

Thanks for working on this one!

[jjyao]

I asked chatgpt, seems changing sys.modules is considered a discouraged way of vendoring. Instead, we should check in the source code directly (see. ray/_private/thirdparty). I'm having a PR for setproctitle (#53471). Could you open a PR for colorama to check in it's source code to ray/_private/thirdparty. It should be straightforward since it's a python only library.

[github-actions]

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

[github-actions]

This pull request has been automatically closed because there has been no more activity in the 14 days
since being marked stale.

Please feel free to reopen or open a new pull request if you'd still like this to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for your contribution!