Skip to content

Conversation

@lk-chen
Copy link
Contributor

@lk-chen lk-chen commented May 9, 2025

Why are these changes needed?

PP backend argument is defaulted to "mp", but as of vLLM 0.8.5, vLLM V1 does not accept "mp" and requires "ray", otherwise it will fall back to V0.

There's recent vllm-project/vllm#14219 to come up in next release, to support "mp" in V1.

Our release test should catch "ray" backend only, hence this PR.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@lk-chen lk-chen requested a review from ruisearch42 May 9, 2025 23:28
@lk-chen lk-chen added go add ONLY when ready to merge, run all tests data Ray Data-related issues release-test release test llm labels May 9, 2025
@hainesmichaelc hainesmichaelc added the community-contribution Contributed by the community label May 12, 2025
@lk-chen lk-chen changed the title [ray.data.llm] Update release test: enforce pp_backend and mp_method [ray.data.llm] Update release test: enforce pp_backend May 18, 2025
lk-chen added 3 commits May 18, 2025 12:34
Signed-off-by: Linkun <github@lkchen.net>
Signed-off-by: Linkun <github@lkchen.net>
Signed-off-by: Linkun <github@lkchen.net>
@lk-chen lk-chen force-pushed the enforce_pp_backend branch from 797f0b9 to 6738d95 Compare May 18, 2025 19:36
@lk-chen lk-chen closed this May 28, 2025
@lk-chen lk-chen deleted the enforce_pp_backend branch May 28, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community data Ray Data-related issues go add ONLY when ready to merge, run all tests llm release-test release test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants