[Train] move collective implementations to train_fn_utils #55689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xgui <xgui@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors collective operations like barrier and broadcast_from_rank_zero by moving their implementations from the public API module ray.train.collective.collectives to the internal TrainFnUtils class. This is a good architectural improvement that cleans up the public API surface and centralizes training-related utilities. The tests have been updated to reflect these changes. The changes are logical and well-executed. I have a couple of minor suggestions to improve code clarity and avoid redundant function calls.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Xinyuan <43737116+xinyuangui2@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Xinyuan <43737116+xinyuangui2@users.noreply.github.com>
justinvyu
reviewed
Aug 21, 2025
Signed-off-by: xgui <xgui@anyscale.com>
TimothySeah
approved these changes
Aug 21, 2025
| @@ -0,0 +1,56 @@ | |||
| import logging | |||
Contributor
There was a problem hiding this comment.
nit: move to collective folder as per @justinvyu 's comment.
Contributor
Author
There was a problem hiding this comment.
We discussed offline and it made more sense to put inside the _internal/execution
Signed-off-by: xgui <xgui@anyscale.com>
justinvyu
approved these changes
Aug 22, 2025
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
…t#55689) This PR moves the implementations of collectives to `TrainFnUtils`. This would unblock the local mode that is introduced in ray-project#55487 --------- Signed-off-by: xgui <xgui@anyscale.com> Signed-off-by: Xinyuan <43737116+xinyuangui2@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
This PR moves the implementations of collectives to `TrainFnUtils`. This would unblock the local mode that is introduced in #55487 --------- Signed-off-by: xgui <xgui@anyscale.com> Signed-off-by: Xinyuan <43737116+xinyuangui2@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…t#55689) This PR moves the implementations of collectives to `TrainFnUtils`. This would unblock the local mode that is introduced in ray-project#55487 --------- Signed-off-by: xgui <xgui@anyscale.com> Signed-off-by: Xinyuan <43737116+xinyuangui2@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR moves the implementations of collectives to
TrainFnUtils. This would unblock the local mode that is introduced in #55487Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.