[core] (cgroups 5/n) Adding clean up methods to CgroupDriverInterface and SysFsCgroupDriver #56255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to perform cgroup operations. Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
instead of clone for older kernel headers < 5.7 (which is what we have in CI) Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Ibrahim Rabbani <israbbani@gmail.com>
…irabbani/cgroups-1
Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Ibrahim Rabbani <israbbani@gmail.com>
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Ibrahim Rabbani <israbbani@gmail.com>
…irabbani/cgroups-1
Signed-off-by: irabbani <irabbani@anyscale.com>
fix CI. Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: Ibrahim Rabbani <irabbani@anyscale.com>
Signed-off-by: irabbani <irabbani@anyscale.com>
…irabbani/cgroups-4
CgroupDriverInterface and SysFsCgroupDriver for cleanup along with unit and integration tests - DeleteCgroup - DisableController Signed-off-by: irabbani <irabbani@anyscale.com>
israbbani
added
go
israbbani
changed the title
16 tasks
Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: Ibrahim Rabbani <irabbani@anyscale.com>
edoakes
approved these changes
Sep 8, 2025
Comment on lines
+94
to
+98
| if (!delete_cgroup_s_.ok()) { | ||
| return delete_cgroup_s_; | ||
| } | ||
| cgroups_->erase(cgroup); | ||
| return delete_cgroup_s_; |
| << "Error: " << strerror(errno); | ||
| } | ||
|
|
||
| // Tests for DeleteCgroup |
Collaborator
There was a problem hiding this comment.
nit: kind of unnecessary comment given test names
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
… and SysFsCgroupDriver (ray-project#56255) This PR stacks on ray-project#56246. For more details about the resource isolation project see ray-project#54703. This PR adds the DeleteCgroup method (along with unit and integration tests) to the CgroupDriverInterface and the SysFsCgroupDriver to allow CgroupManager to clean up the cgroup hierarchy is graceful shutdown. --------- Signed-off-by: Ibrahim Rabbani <irabbani@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
ZacAttack
pushed a commit
to ZacAttack/ray
that referenced
this pull request
Sep 24, 2025
… and SysFsCgroupDriver (ray-project#56255) This PR stacks on ray-project#56246. For more details about the resource isolation project see ray-project#54703. This PR adds the DeleteCgroup method (along with unit and integration tests) to the CgroupDriverInterface and the SysFsCgroupDriver to allow CgroupManager to clean up the cgroup hierarchy is graceful shutdown. --------- Signed-off-by: Ibrahim Rabbani <irabbani@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: zac <zac@anyscale.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
… and SysFsCgroupDriver (#56255) This PR stacks on #56246. For more details about the resource isolation project see #54703. This PR adds the DeleteCgroup method (along with unit and integration tests) to the CgroupDriverInterface and the SysFsCgroupDriver to allow CgroupManager to clean up the cgroup hierarchy is graceful shutdown. --------- Signed-off-by: Ibrahim Rabbani <irabbani@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
8 tasks
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
… and SysFsCgroupDriver (ray-project#56255) This PR stacks on ray-project#56246. For more details about the resource isolation project see ray-project#54703. This PR adds the DeleteCgroup method (along with unit and integration tests) to the CgroupDriverInterface and the SysFsCgroupDriver to allow CgroupManager to clean up the cgroup hierarchy is graceful shutdown. --------- Signed-off-by: Ibrahim Rabbani <irabbani@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
snorkelopstesting2-coder
pushed a commit
to snorkel-marlin-repos/ray-project_ray_pr_56255_10aaf56b-4f01-4ac8-85c5-01d7142718ae
that referenced
this pull request
Oct 22, 2025
… and SysFsCgroupDriver Original PR #56255 by israbbani Original: ray-project/ray#56255
snorkelopstesting1-a11y
added a commit
to snorkel-marlin-repos/ray-project_ray_pr_56255_10aaf56b-4f01-4ac8-85c5-01d7142718ae
that referenced
this pull request
Oct 22, 2025
…o CgroupDriverInterface and SysFsCgroupDriver Merged from original PR #56255 Original: ray-project/ray#56255
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
… and SysFsCgroupDriver (ray-project#56255) This PR stacks on ray-project#56246. For more details about the resource isolation project see ray-project#54703. This PR adds the DeleteCgroup method (along with unit and integration tests) to the CgroupDriverInterface and the SysFsCgroupDriver to allow CgroupManager to clean up the cgroup hierarchy is graceful shutdown. --------- Signed-off-by: Ibrahim Rabbani <irabbani@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stacks on #56246.
For more details about the resource isolation project see #54703.
This PR adds the DeleteCgroup method (along with unit and integration tests) to the CgroupDriverInterface and the SysFsCgroupDriver to allow CgroupManager to clean up the cgroup hierarchy is graceful shutdown.