Skip to content

[Data] - Add alias expression #56550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexeykudinkin merged 12 commits into from
Sep 24, 2025
Merged

[Data] - Add alias expression #56550

alexeykudinkin merged 12 commits into from
Sep 24, 2025

Conversation

@goutamvenkat-anyscale
Copy link
Contributor

@goutamvenkat-anyscale goutamvenkat-anyscale commented Sep 15, 2025

Why are these changes needed?

This change adds support for renaming resultant expressions via alias().

As a result of this change, we can eventually consolidate the Project operator to use only expressions instead of having to support cols and cols_rename in addition to expressions.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@goutamvenkat-anyscale
[Data] - Add alias expression
cd1b91e 
Signed-off-by: Goutam V. <goutam@anyscale.com>
@goutamvenkat-anyscale
Add alias to docs
1104920 
Signed-off-by: Goutam V. <goutam@anyscale.com>
@goutamvenkat-anyscale goutamvenkat-anyscale requested a review from a team as a code owner September 15, 2025 21:27
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 15, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the alias() method for expressions, allowing them to be renamed. This is a key feature for improving the usability of expression-based APIs. The implementation is solid, with good test coverage. I've provided a few suggestions to improve the efficiency of literal expression evaluation and to simplify a test assertion.

@goutamvenkat-anyscale
Doc fix
95c0828 
Signed-off-by: Goutam V. <goutam@anyscale.com>
@goutamvenkat-anyscale goutamvenkat-anyscale added data Ray Data-related issues go add ONLY when ready to merge, run all tests labels Sep 16, 2025
alexeykudinkin
alexeykudinkin reviewed Sep 16, 2025
View reviewed changes
@goutamvenkat-anyscale
Use the name from aliasExpr
2107892 
Signed-off-by: Goutam V. <goutam@anyscale.com>
@goutamvenkat-anyscale
Merge from master + conflicts
245338f 
Signed-off-by: Goutam V. <goutam@anyscale.com>
@goutamvenkat-anyscale
Merge branch 'master' into goutam/alias_expr
e0e33a9
alexeykudinkin
alexeykudinkin approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@alexeykudinkin alexeykudinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

iamjustinhsu
iamjustinhsu reviewed Sep 19, 2025
View reviewed changes
Copy link
Contributor

@iamjustinhsu iamjustinhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ur PRs are now under my scrutiny :)

@goutamvenkat-anyscale
Cleanup + remove aliasexpr + address comments
9521203 
Signed-off-by: Goutam V. <goutam@anyscale.com>
iamjustinhsu
iamjustinhsu approved these changes Sep 19, 2025
View reviewed changes
@goutamvenkat-anyscale
Fix test
3153ee3 
Signed-off-by: Goutam V. <goutam@anyscale.com>
cursor[bot]

This comment was marked as outdated.

Sign in to view

alexeykudinkin
alexeykudinkin requested changes Sep 22, 2025
View reviewed changes
cursor[bot]

This comment was marked as outdated.

Sign in to view

alexeykudinkin
alexeykudinkin approved these changes Sep 23, 2025
View reviewed changes
@goutamvenkat-anyscale
Address comments
3cade97 
Signed-off-by: Goutam V. <goutam@anyscale.com>
cursor[bot]

This comment was marked as outdated.

Sign in to view

@goutamvenkat-anyscale
Fix test
c4ad0e8 
Signed-off-by: Goutam V. <goutam@anyscale.com>
@alexeykudinkin alexeykudinkin merged commit f6021d8 into ray-project:master Sep 24, 2025
6 checks passed
marcostephan pushed a commit to marcostephan/ray that referenced this pull request Sep 24, 2025
@goutamvenkat-anyscale @marcostephan
[Data] - Add alias expression (ray-project#56550)
50c231f 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This change adds support for renaming resultant expressions via
`alias()`.

As a result of this change, we can eventually consolidate the Project
operator to use only expressions instead of having to support `cols` and
`cols_rename` in addition to expressions.

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Goutam V. <goutam@anyscale.com>
Signed-off-by: Marco Stephan <marco@magic.dev>
elliot-barn pushed a commit that referenced this pull request Sep 27, 2025
@goutamvenkat-anyscale @elliot-barn
[Data] - Add alias expression (#56550)
710a434 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This change adds support for renaming resultant expressions via
`alias()`.

As a result of this change, we can eventually consolidate the Project
operator to use only expressions instead of having to support `cols` and
`cols_rename` in addition to expressions.

## Related issue number

<!-- For example: "Closes #1234" -->

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Goutam V. <goutam@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
dstrodtman pushed a commit to dstrodtman/ray that referenced this pull request Oct 6, 2025
@goutamvenkat-anyscale @dstrodtman
[Data] - Add alias expression (ray-project#56550)
8f73a91 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This change adds support for renaming resultant expressions via
`alias()`.

As a result of this change, we can eventually consolidate the Project
operator to use only expressions instead of having to support `cols` and
`cols_rename` in addition to expressions.

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Goutam V. <goutam@anyscale.com>
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
justinyeh1995 pushed a commit to justinyeh1995/ray that referenced this pull request Oct 20, 2025
@goutamvenkat-anyscale @justinyeh1995
[Data] - Add alias expression (ray-project#56550)
c9c7183 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This change adds support for renaming resultant expressions via
`alias()`.

As a result of this change, we can eventually consolidate the Project
operator to use only expressions instead of having to support `cols` and
`cols_rename` in addition to expressions.

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Goutam V. <goutam@anyscale.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
@goutamvenkat-anyscale @landscapepainter
[Data] - Add alias expression (ray-project#56550)
468caf2 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This change adds support for renaming resultant expressions via
`alias()`.

As a result of this change, we can eventually consolidate the Project
operator to use only expressions instead of having to support `cols` and
`cols_rename` in addition to expressions.

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Goutam V. <goutam@anyscale.com>
Future-Outlier pushed a commit to Future-Outlier/ray that referenced this pull request Dec 7, 2025
@goutamvenkat-anyscale @Future-Outlier
[Data] - Add alias expression (ray-project#56550)
5cb5dd7 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This change adds support for renaming resultant expressions via
`alias()`.

As a result of this change, we can eventually consolidate the Project
operator to use only expressions instead of having to support `cols` and
`cols_rename` in addition to expressions.

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Goutam V. <goutam@anyscale.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@alexeykudinkin alexeykudinkin alexeykudinkin approved these changes

@iamjustinhsu iamjustinhsu iamjustinhsu approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

data Ray Data-related issues go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goutamvenkat-anyscale @alexeykudinkin @iamjustinhsu