[RLlib] LINT: Enable ruff imports for rllib/algorithms and rllib/utils
#56734
Conversation
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
ray-gardener
bot
added
rllib
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables ruff import sorting for the rllib/algorithms directory. The changes primarily consist of reordering imports across numerous files to adhere to the new linting rules, which is a great step towards code consistency.
My review has identified a couple of instances where the automated changes have introduced duplicate imports. These should be addressed to maintain code quality. Otherwise, the changes look good and align with the PR's objective.
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
Signed-off-by: Kamil Kaczmarek <kaczmarek.poczta@gmail.com>
kamil-kaczmarek
left a comment
kamil-kaczmarek
left a comment
There was a problem hiding this comment.
LGTM! Great contribution 🚀
kamil-kaczmarek
changed the title
rllib/algorithmsrllib/algorithms
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
Signed-off-by: Kamil Kaczmarek <kaczmarek.poczta@gmail.com>
Signed-off-by: Kamil Kaczmarek <kaczmarek.poczta@gmail.com>
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
github-actions
bot
added
the
stale
Signed-off-by: Kamil Kaczmarek <kaczmarek.poczta@gmail.com>
github-actions
bot
added
unstale
|
@czgdp1807 We've resolved the CI problem (though there might still be problems) therefore could you resolve the merge conflicts and we'll try to merge them iteratively |
# Conflicts: # pyproject.toml # rllib/core/learner/learner_group.py
Signed-off-by: Mark Towers <mark@anyscale.com>
# Conflicts: # pyproject.toml # rllib/env/env_runner.py # rllib/env/single_agent_episode.py
Signed-off-by: Mark Towers <mark@anyscale.com>
# Conflicts: # pyproject.toml # rllib/algorithms/algorithm.py # rllib/algorithms/appo/utils.py # rllib/algorithms/impala/impala.py # rllib/algorithms/impala/impala_learner.py
Signed-off-by: Mark Towers <mark@anyscale.com>
# Conflicts: # pyproject.toml
Signed-off-by: Mark Towers <mark@anyscale.com>
pseudo-rnd-thoughts
changed the title
rllib/algorithmsrllib/algorithms and rllib/utils
Signed-off-by: Mark Towers <mark@anyscale.com>
…b/utils`` (ray-project#56734) Signed-off-by: Aydin Abiar <aydin@anyscale.com>
…b/utils`` (ray-project#56734) Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
6 participants
Why are these changes needed?
First split of #56416
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.