-
Notifications
You must be signed in to change notification settings - Fork 7k
[RLlib] LINT: Enable ruff imports for offline/, tests/, callbacks/ and env/ in rllib
#56744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] LINT: Enable ruff imports for offline/, tests/, callbacks/ and env/ in rllib
#56744
Conversation
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
LINT: Enable ruff imports for offline/, tests/, callbacks/ and env in rllib`offline/, tests/, callbacks/ and env in rllib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enables ruff for import sorting on offline/, tests/, callbacks/, and env/ directories within rllib. The changes consist of updating pyproject.toml to remove these directories from the isort ignore list and applying the corresponding import reordering across numerous files in these directories. The changes are purely stylistic and align with the project's linting standards. The import reordering has been applied correctly across all modified files. The PR is a good step towards standardizing the codebase.
offline/, tests/, callbacks/ and env in rlliboffline/, tests/, callbacks/ and env in rllib
offline/, tests/, callbacks/ and env in rlliboffline/, tests/, callbacks/ and env/ in rllib
kamil-kaczmarek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work
|
@czgdp1807 apologies, I was trying to fix the merge conflicts through the github web ui however it doesn't include the commit sign off that DCO requires. We can merge this PR last of your linting PRs but it will require you to rebase the PR to resolve this issue |
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
310e76b to
a6af7a4
Compare
|
@pseudo-rnd-thoughts @kamil-kaczmarek I have merged |
|
@czgdp1807 could you resolve them sadly. I suspect that we'll need to wait to premerge to pass then merge then fix the new conflicts on another one of the PRs until they're all complete |
|
No problems @pseudo-rnd-thoughts. This is expected to happen. Resolving them. |
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
|
@pseudo-rnd-thoughts Done. |
|
@czgdp1807 There is a problem in the CI thats unrelated to your PR that were trying to actively fix in #57067 I'll ping you when the CI problem is resolved and if there is anything we need you to do |
Signed-off-by: Kamil Kaczmarek <kaczmarek.poczta@gmail.com>
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
|
unstale |
# Conflicts: # pyproject.toml # rllib/core/learner/learner_group.py
Signed-off-by: Mark Towers <mark@anyscale.com>
# Conflicts: # pyproject.toml # rllib/env/env_runner.py # rllib/env/single_agent_episode.py
Signed-off-by: Mark Towers <mark@anyscale.com>
…lbacks/`` and ``env/`` in ``rllib`` (ray-project#56744)
…lbacks/`` and ``env/`` in ``rllib`` (ray-project#56744)
…lbacks/`` and ``env/`` in ``rllib`` (ray-project#56744) Signed-off-by: Aydin Abiar <aydin@anyscale.com>
…lbacks/`` and ``env/`` in ``rllib`` (ray-project#56744)
Why are these changes needed?
Sixth split of #56416
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.Note
Updates Ruff config to target specific rllib subpaths and performs widespread import reordering/normalization across callbacks, env, offline, and tests (no functional changes).
pyproject.tomlRuff per-file-ignores fromrllib/*to specific subpaths (e.g.,rllib/{algorithms,core,examples,...}) for finer-grained linting.__init__and wrappers.Written by Cursor Bugbot for commit a6af7a4. This will update automatically on new commits. Configure here.