[core] Unexpected system exit instead of objects_valid crash on exception #57247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h when task execution code throws an exception Signed-off-by: dayshah <dhyey2019@gmail.com>
jjyao
approved these changes
Oct 7, 2025
aslonnie
added a commit
that referenced
this pull request
Oct 8, 2025
liulehui
pushed a commit
to liulehui/ray
that referenced
this pull request
Oct 9, 2025
…tion (ray-project#57247) Signed-off-by: dayshah <dhyey2019@gmail.com>
joshkodi
pushed a commit
to joshkodi/ray
that referenced
this pull request
Oct 13, 2025
…tion (ray-project#57247) Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Josh Kodi <joshkodi@gmail.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
…tion (ray-project#57247) Signed-off-by: dayshah <dhyey2019@gmail.com>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
…tion (ray-project#57247) Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: xgui <xgui@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…tion (ray-project#57247) Signed-off-by: dayshah <dhyey2019@gmail.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…tion (ray-project#57247) Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…tion (ray-project#57247) Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently if the task_execution_handler in _raylet.pyx throws an exception before we can get into the actual task handling code that catches all exceptions, cython will end up just continuing execution to return Status::OK. This means that we could finish ExecuteTask with Status::OK and a return objects vector that has empty objects leading to the dreaded objects_valid check failure.
Instead of a check failure this will catch the exception, log an error, and return an UnexpectedSystemExit with the exception information so the worker can exit gracefully and the driver can get the exception information for better debuggability. For example: #57253 was hard to figure out for a long time because we didn't know why we were skipping the object storing phase in Cython. This would've made it much easier.