[train] Enable deprecation warning for legacy xgboost/lightgbm trainer APIs #57280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables deprecation warnings for the legacy XGBoost and LightGBM trainer APIs. The changes look good and achieve the intended goal. My feedback focuses on improving the clarity and consistency of the new user-facing warning messages to ensure they are as helpful as possible.
matthewdeng
approved these changes
Oct 7, 2025
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
liulehui
pushed a commit
to liulehui/ray
that referenced
this pull request
Oct 9, 2025
…r APIs (ray-project#57280) Emit the deprecation warning for the legacy XGBoostTrainer API, in preparation for Train V2 migration (which only supports the new custom training function API). --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com>
joshkodi
pushed a commit
to joshkodi/ray
that referenced
this pull request
Oct 13, 2025
…r APIs (ray-project#57280) Emit the deprecation warning for the legacy XGBoostTrainer API, in preparation for Train V2 migration (which only supports the new custom training function API). --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Josh Kodi <joshkodi@gmail.com>
ArturNiederfahrenhorst
pushed a commit
to ArturNiederfahrenhorst/ray
that referenced
this pull request
Oct 13, 2025
…r APIs (ray-project#57280) Emit the deprecation warning for the legacy XGBoostTrainer API, in preparation for Train V2 migration (which only supports the new custom training function API). --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
…r APIs (ray-project#57280) Emit the deprecation warning for the legacy XGBoostTrainer API, in preparation for Train V2 migration (which only supports the new custom training function API). --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
…r APIs (ray-project#57280) Emit the deprecation warning for the legacy XGBoostTrainer API, in preparation for Train V2 migration (which only supports the new custom training function API). --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: xgui <xgui@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
…r APIs (#57280) Emit the deprecation warning for the legacy XGBoostTrainer API, in preparation for Train V2 migration (which only supports the new custom training function API). --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…r APIs (ray-project#57280) Emit the deprecation warning for the legacy XGBoostTrainer API, in preparation for Train V2 migration (which only supports the new custom training function API). --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…r APIs (ray-project#57280) Emit the deprecation warning for the legacy XGBoostTrainer API, in preparation for Train V2 migration (which only supports the new custom training function API). --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…r APIs (ray-project#57280) Emit the deprecation warning for the legacy XGBoostTrainer API, in preparation for Train V2 migration (which only supports the new custom training function API). --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Emit the deprecation warning for the legacy XGBoostTrainer API, in preparation for Train V2 migration (which only supports the new custom training function API).
Links to this issue with migration support: #50042
Example output