[release] release data batch inference tests #57287
Conversation
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades several batch inference and Dask-on-Ray tests to Python 3.10. The changes are straightforward and correct. To improve the maintainability of these YAML configuration files, I've suggested using YAML anchors and aliases. This approach centralizes the Python version, making future updates across these related tests simpler and less prone to error. It's a small refactoring that will enhance the configuration's clarity and ease of maintenance.
| # 300 GB image classification parquet data up to 10 GPUs | ||
| # 10 g4dn.12xlarge. | ||
| - name: "image_classification_{{scaling}}" | ||
| python: "3.10" |
There was a problem hiding this comment.
To improve maintainability and reduce repetition, you can define a YAML anchor for the Python version here. This allows you to reuse the value in other test configurations within this file by using an alias, making future updates to the Python version much easier and less error-prone.
python: &py310 "3.10"| --data-directory 300G-image-data-synthetic-raw-parquet --data-format parquet | ||
| - name: image_classification_chaos | ||
| python: "3.10" |
There was a problem hiding this comment.
Please use the YAML alias *py310 defined earlier. This will make the configuration more maintainable.
python: *py310
release/release_data_tests.yaml
Outdated
| --data-directory 300G-image-data-synthetic-raw-parquet --data-format parquet --chaos-test | ||
| - name: image_classification_chaos_no_scale_back | ||
| python: "3.10" |
There was a problem hiding this comment.
Let's use the *py310 alias here for consistency.
python: *py310| - name: image_embedding_from_uris_{{case}} | ||
| python: "3.10" |
There was a problem hiding this comment.
Using the *py310 alias here will help with future maintenance.
python: *py310
release/release_data_tests.yaml
Outdated
|
|
||
|
|
||
| - name: image_embedding_from_jsonl_{{case}} | ||
| python: "3.10" |
There was a problem hiding this comment.
Same as above, please use the *py310 alias.
python: *py310| script: python image_embedding_from_jsonl/main.py {{args}} | ||
|
|
||
| - name: text_embedding_{{case}} | ||
| python: "3.10" |
There was a problem hiding this comment.
And here as well, please use the *py310 alias.
python: *py310| - __suffix__: aws | ||
|
|
||
| - name: chaos_dask_on_ray_large_scale_test_no_spilling | ||
| python: "3.10" |
There was a problem hiding this comment.
To improve maintainability and reduce repetition, you can define a YAML anchor for the Python version here. This allows you to reuse the value in the subsequent test configuration within this file by using an alias, making future updates to the Python version easier.
python: &py310 "3.10"| cluster_compute: dask_on_ray/dask_on_ray_stress_compute_gce.yaml | ||
|
|
||
| - name: chaos_dask_on_ray_large_scale_test_spilling | ||
| python: "3.10" |
There was a problem hiding this comment.
To maintain consistency and improve maintainability, please use the YAML alias *py310 here, as defined in the chaos_dask_on_ray_large_scale_test_no_spilling test.
python: *py310
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
…-data-batch-inference-tests
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
upgrading batch inference tests to py3.10 Successful release test run: https://buildkite.com/ray-project/release/builds/65258 all except for image_embedding_from_jsonl are running on python 3.10 --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com> Signed-off-by: xgui <xgui@anyscale.com>
upgrading batch inference tests to py3.10 Successful release test run: https://buildkite.com/ray-project/release/builds/65258 all except for image_embedding_from_jsonl are running on python 3.10 --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
upgrading batch inference tests to py3.10 Successful release test run: https://buildkite.com/ray-project/release/builds/65258 all except for image_embedding_from_jsonl are running on python 3.10 --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
upgrading batch inference tests to py3.10 Successful release test run: https://buildkite.com/ray-project/release/builds/65258 all except for image_embedding_from_jsonl are running on python 3.10 --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
upgrading batch inference tests to py3.10
Successful release test run: https://buildkite.com/ray-project/release/builds/65258
all except for image_embedding_from_jsonl are running on python 3.10