Skip to content

Conversation

@israbbani
Copy link
Contributor

@israbbani israbbani commented Oct 10, 2025

The MacOS + Java CI takes up a lot of time to debug. Here are a few improvements

  • Removing logic to find the network interface on the machine. It fails if we have different interfaces that the test expects. Instead, we can just let ray use loclahost.
  • Deleting a test that just spams log lines to buildkite output. It's to test log4j performance, but it doesn't assert anything.

Signed-off-by: irabbani <israbbani@gmail.com>
@israbbani israbbani added the go add ONLY when ready to merge, run all tests label Oct 10, 2025
- removing logic that tries to find the machine's ip address. Let ray
  use localhost.
- removing a test that just logs out 2,000,000 lines in an actor and
  then prints how long it took. No assertions...

Signed-off-by: irabbani <israbbani@gmail.com>
@israbbani israbbani changed the title [do-not-merge] debugging macos tests [core] Making MacOS + Java tests a little less unpleasant Oct 10, 2025
Signed-off-by: irabbani <israbbani@gmail.com>
Signed-off-by: irabbani <israbbani@gmail.com>
Signed-off-by: irabbani <israbbani@gmail.com>
Signed-off-by: irabbani <israbbani@gmail.com>
Signed-off-by: irabbani <israbbani@gmail.com>
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 30, 2025
@github-actions
Copy link

This pull request has been automatically closed because there has been no more activity in the 14 days
since being marked stale.

Please feel free to reopen or open a new pull request if you'd still like this to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for your contribution!

@github-actions github-actions bot closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests stale The issue is stale. It will be closed within 7 days unless there are further conversation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants