[3/n] Add support for application level autoscaling #57637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
abrarsheikh
changed the title
Signed-off-by: abrar <abrar@anyscale.com>
arcyleung
reviewed
Oct 12, 2025
| ), | ||
| ) | ||
| else: | ||
| self._autoscaling_state_manager.deregister_application(self._name) |
Contributor
There was a problem hiding this comment.
Is it possible to have a lingering registration if the same app_name was built with BuildAppStatus.SUCCEEDED the first time, but failed to build the second time around?
Contributor
Author
There was a problem hiding this comment.
but if it failed, wouldn't user retry deploy the app anyway.
abrarsheikh
force-pushed
the
SERVE-1216-abrar-auto
branch
from
dbf3f53 to
d7d25d2
Compare
Signed-off-by: abrar <abrar@anyscale.com>
abrarsheikh
force-pushed
the
SERVE-1216-abrar-auto
branch
from
d7d25d2 to
9c3b266
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Kishanthan
reviewed
Oct 15, 2025
Signed-off-by: abrar <abrar@anyscale.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
zcin
reviewed
Oct 16, 2025
zcin
reviewed
Oct 16, 2025
Signed-off-by: abrar <abrar@anyscale.com>
| self._autoscaling_state_manager.register_application( | ||
| self._name, | ||
| AutoscalingPolicy(**checkpoint_data.config.autoscaling_policy), | ||
| ) |
There was a problem hiding this comment.
Bug: Type Error When Unpacking Autoscaling Policy
The code attempts to unpack autoscaling_policy into an AutoscalingPolicy object using **, assuming it's always a dictionary. This can raise a TypeError if autoscaling_policy is already an AutoscalingPolicy instance, potentially after Pydantic deserialization. This occurs during checkpoint restoration and when setting the application's target state.
Additional Locations (1)
zcin
approved these changes
Oct 16, 2025
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
Phase 3 of https://gist.github.com/abrarsheikh/abde819a199c2190baba082f0e6fdd86 --------- Signed-off-by: abrar <abrar@anyscale.com>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
Phase 3 of https://gist.github.com/abrarsheikh/abde819a199c2190baba082f0e6fdd86 --------- Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: xgui <xgui@anyscale.com>
snorkelopstesting1-a11y
pushed a commit
to snorkel-marlin-repos/ray-project_ray_pr_57637_de7fa4cf-ea41-4ee9-a4f3-aa25c759127a
that referenced
this pull request
Oct 22, 2025
Original PR #57637 by abrarsheikh Original: ray-project/ray#57637
snorkelopstesting4-web
added a commit
to snorkel-marlin-repos/ray-project_ray_pr_57637_de7fa4cf-ea41-4ee9-a4f3-aa25c759127a
that referenced
this pull request
Oct 22, 2025
…aling Merged from original PR #57637 Original: ray-project/ray#57637
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
Phase 3 of https://gist.github.com/abrarsheikh/abde819a199c2190baba082f0e6fdd86 --------- Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
Phase 3 of https://gist.github.com/abrarsheikh/abde819a199c2190baba082f0e6fdd86 --------- Signed-off-by: abrar <abrar@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
Phase 3 of https://gist.github.com/abrarsheikh/abde819a199c2190baba082f0e6fdd86 --------- Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
Phase 3 of https://gist.github.com/abrarsheikh/abde819a199c2190baba082f0e6fdd86 --------- Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 3 of https://gist.github.com/abrarsheikh/abde819a199c2190baba082f0e6fdd86