Skip to content

[Data][CI] Add fix_block.py back to CI #57841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bveeramani merged 5 commits into from
Oct 23, 2025
Merged

[Data][CI] Add fix_block.py back to CI #57841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
242ad55
update
owenowenisme Oct 17, 2025
c1b39fd
update
owenowenisme Oct 17, 2025
28e9ece
update
Oct 18, 2025
be82188
Merge branch 'master' into data/fix-test-block
owenowenisme Oct 18, 2025
1dbce70
fix
owenowenisme Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions python/ray/data/_internal/arrow_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,9 +539,13 @@ def to_pylist(self) -> List[Any]:
return self._column.to_pylist()

def to_numpy(self, zero_copy_only: bool = False) -> np.ndarray:
# NOTE: Pyarrow < 13.0.0 does not support ``zero_copy_only``
if get_pyarrow_version() < _MIN_PYARROW_VERSION_TO_NUMPY_ZERO_COPY_ONLY:
Copy link
Member

@bveeramani bveeramani Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Might be worth renaming _MIN_PYARROW_VERSION_TO_NUMPY_ZERO_COPY_ONLY to clarify that it only applies to ChunkedArray, but I guess the name would get pretty verbose.

Will defer to you

Copy link
Member Author

@owenowenisme owenowenisme Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_MIN_PYARROW_VERSION_TO_NUMPY_ZERO_COPY_ONLY is single usage at this time, I think we can leave it as it is for now.

return self._column.to_numpy()
if isinstance(
self._column, pyarrow.ChunkedArray
): # NOTE: ChunkedArray in Pyarrow < 13.0.0 does not support ``zero_copy_only``
return self._column.to_numpy()
else:
return self._column.to_numpy(zero_copy_only=zero_copy_only)

return self._column.to_numpy(zero_copy_only=zero_copy_only)

Expand Down
6 changes: 6 additions & 0 deletions python/ray/data/tests/test_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,3 +156,9 @@ def test_find_partitions_duplicates():
assert partitions[1].to_pydict() == {"value": []} # [1,2)
assert partitions[2].to_pydict() == {"value": [2, 2, 2, 2, 2]} # [2,3)
assert partitions[3].to_pydict() == {"value": []} # >=3


if __name__ == "__main__":
import sys

sys.exit(pytest.main(["-v", __file__]))
1 change: 0 additions & 1 deletion semgrep.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ rules:
exclude:
# FIXME: These tests weren't run in CI, and now they're failing.
- "python/ray/data/tests/test_arrow_serialization.py"
- "python/ray/data/tests/test_block.py"
- "python/ray/data/tests/test_hash_shuffle.py"
- "python/ray/data/tests/test_operator_fusion.py"
languages:
Expand Down