[Data] [2/n] - Update Project operator to use Expressions #57855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a significant and positive refactoring that updates the Project operator to use a more general and powerful expression-based API. This simplifies the logical plan and enables more robust optimizations, as shown by the rewrite of the projection pushdown rule. The addition of comprehensive tests for the new expression logic is also a great improvement. I've found one critical issue with the count() implementation and a couple of medium-severity suggestions for performance and code style.
python/ray/data/_internal/planner/plan_expression/expression_evaluator.py
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
goutamvenkat-anyscale
force-pushed
the
goutam/expr_project_2_n
branch
from
b8bc299 to
467dcdb
Compare
goutamvenkat-anyscale
added
data
python/ray/data/_internal/planner/plan_expression/expression_evaluator.py
Outdated
Show resolved
Hide resolved
goutamvenkat-anyscale
force-pushed
the
goutam/expr_project_2_n
branch
from
467dcdb to
b9b1905
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
goutamvenkat-anyscale
force-pushed
the
goutam/expr_project_2_n
branch
2 times, most recently
from
2b6da29 to
d9ef6e1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
goutamvenkat-anyscale
force-pushed
the
goutam/expr_project_2_n
branch
2 times, most recently
from
dab9ffa to
8f06393
Compare
8 tasks
python/ray/data/_internal/planner/plan_expression/expression_visitors.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/planner/plan_expression/expression_visitors.py
Outdated
Show resolved
Hide resolved
goutamvenkat-anyscale
force-pushed
the
goutam/expr_project_2_n
branch
3 times, most recently
from
1d995c9 to
4f9a2cc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
goutamvenkat-anyscale
force-pushed
the
goutam/expr_project_2_n
branch
from
4f9a2cc to
1cd247b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
goutamvenkat-anyscale
force-pushed
the
goutam/expr_project_2_n
branch
from
1cd247b to
dba8fc8
Compare
alexeykudinkin
approved these changes
Oct 22, 2025
Signed-off-by: Goutam <goutam@anyscale.com>
goutamvenkat-anyscale
force-pushed
the
goutam/expr_project_2_n
branch
from
dba8fc8 to
22ddef1
Compare
Vito-Yang
added a commit
to Vito-Yang/ray
that referenced
this pull request
Oct 22, 2025
[Data] [2/n] - Update Project operator to use Expressions (ray-project#57855)
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…t#57855) > Thank you for contributing to Ray! 🚀 > Please review the [Ray Contribution Guide](https://docs.ray.io/en/master/ray-contribute/getting-involved.html) before opening a pull request. ## Description 1. Add visitors for collecting column names from all expressions and renaming names across the tree. 2. Use expressions for rename_columns, with_column, select_columns and remove cols and cols_rename in Project 3. Modify Projection Pushdown to work with combinations of the above operators correctly ## Related issues Closes ray-project#56878, ray-project#57700 ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: Goutam <goutam@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…t#57855) > Thank you for contributing to Ray! 🚀 > Please review the [Ray Contribution Guide](https://docs.ray.io/en/master/ray-contribute/getting-involved.html) before opening a pull request. ## Description 1. Add visitors for collecting column names from all expressions and renaming names across the tree. 2. Use expressions for rename_columns, with_column, select_columns and remove cols and cols_rename in Project 3. Modify Projection Pushdown to work with combinations of the above operators correctly ## Related issues Closes ray-project#56878, ray-project#57700 ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: Goutam <goutam@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Closes #56878, #57700
Additional information