[Serve][Add] Include custom autoscaling policy name in logs #57878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. Change-Id: I0ba11bdb5e07c30f23a596dfd081bffbbe4beac5 Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds logging to indicate when a custom autoscaling policy is being used, both at the deployment and application level. This is a good improvement for observability. My review includes a suggestion to improve the log message format for consistency and a recommendation to add unit tests to verify the new logging behavior.
ray-gardener
bot
added
serve
abrarsheikh
approved these changes
Oct 27, 2025
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…ect#57878) ## Description Now, we hava custom autoscaling policy name in logs. 1. Deployment level Test code from https://docs.ray.io/en/master/serve/advanced-guides/advanced-autoscaling.html#custom-policy-for-deployment <img width="1333" height="294" alt="image" src="https://github.com/user-attachments/assets/bd26e576-fd3c-489b-94c2-4c11b25bb400" /> 2. Application level Test code from https://docs.ray.io/en/master/serve/advanced-guides/advanced-autoscaling.html#application-level-autoscaling <img width="1321" height="431" alt="image" src="https://github.com/user-attachments/assets/d51f4952-faf5-47eb-80d0-6be357437505" /> ## Related issues Closes ray-project#57846 ## Additional information Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…ect#57878) ## Description Now, we hava custom autoscaling policy name in logs. 1. Deployment level Test code from https://docs.ray.io/en/master/serve/advanced-guides/advanced-autoscaling.html#custom-policy-for-deployment <img width="1333" height="294" alt="image" src="https://github.com/user-attachments/assets/bd26e576-fd3c-489b-94c2-4c11b25bb400" /> 2. Application level Test code from https://docs.ray.io/en/master/serve/advanced-guides/advanced-autoscaling.html#application-level-autoscaling <img width="1321" height="431" alt="image" src="https://github.com/user-attachments/assets/d51f4952-faf5-47eb-80d0-6be357437505" /> ## Related issues Closes ray-project#57846 ## Additional information Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…ect#57878) ## Description Now, we hava custom autoscaling policy name in logs. 1. Deployment level Test code from https://docs.ray.io/en/master/serve/advanced-guides/advanced-autoscaling.html#custom-policy-for-deployment <img width="1333" height="294" alt="image" src="https://github.com/user-attachments/assets/bd26e576-fd3c-489b-94c2-4c11b25bb400" /> 2. Application level Test code from https://docs.ray.io/en/master/serve/advanced-guides/advanced-autoscaling.html#application-level-autoscaling <img width="1321" height="431" alt="image" src="https://github.com/user-attachments/assets/d51f4952-faf5-47eb-80d0-6be357437505" /> ## Related issues Closes ray-project#57846 ## Additional information Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now, we hava custom autoscaling policy name in logs.
Test code from https://docs.ray.io/en/master/serve/advanced-guides/advanced-autoscaling.html#custom-policy-for-deployment
Test code from https://docs.ray.io/en/master/serve/advanced-guides/advanced-autoscaling.html#application-level-autoscaling
Related issues
Closes #57846
Additional information