Skip to content

Conversation

@aslonnie
Copy link
Collaborator

result_of_t is deprecated

`result_of_t` is deprecated

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
@aslonnie aslonnie requested review from a team, SongGuyang, kfstorm and raulchen as code owners October 19, 2025 01:36
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces the deprecated std::result_of_t with std::invoke_result_t in the simple_kv_store.cc example. The change is a direct replacement that aligns with modern C++ standards (C++17 and later). The change is correct and the pull request is good to merge.

@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Oct 19, 2025
@ray-gardener ray-gardener bot added docs An issue or change related to documentation core Issues that should be addressed in Ray Core labels Oct 19, 2025
@aslonnie aslonnie merged commit 697c7bc into master Oct 19, 2025
6 checks passed
@aslonnie aslonnie deleted the lonnie-250918-resultof branch October 19, 2025 16:41
justinyeh1995 pushed a commit to justinyeh1995/ray that referenced this pull request Oct 20, 2025
`result_of_t` is deprecated

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
xinyuangui2 pushed a commit to xinyuangui2/ray that referenced this pull request Oct 22, 2025
`result_of_t` is deprecated

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: xgui <xgui@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Oct 23, 2025
`result_of_t` is deprecated

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
`result_of_t` is deprecated

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
`result_of_t` is deprecated

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core docs An issue or change related to documentation go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants