[train] bump test_util timeout #57939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the timeout for the test_util test from small to medium to fix timeouts on Python 3.12. This is a reasonable change to improve test stability. The underlying cause of the slowness appears to be inefficient test setup in test_util.py, where a Ray cluster is repeatedly started and stopped for parameterized tests. A future optimization could be to use a module-scoped fixture to share the cluster across tests, which would be much faster. However, since that file isn't part of this PR, the proposed change is a valid fix for now.
JasonLi1909
approved these changes
Oct 21, 2025
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
## Description Bumping from small to medium because it's timing out for Python 3.12. Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com> Signed-off-by: xgui <xgui@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
## Description Bumping from small to medium because it's timing out for Python 3.12. Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
## Description Bumping from small to medium because it's timing out for Python 3.12. Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
## Description Bumping from small to medium because it's timing out for Python 3.12. Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumping from small to medium because it's timing out for Python 3.12.