[train] disable train_colocate_trainer #57963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly disables the train_colocate_trainer release test by changing its frequency to manual. This is necessary because the test relies on ScalingConfig.trainer_resources, which has been deprecated in Ray Train V2. The added comments provide helpful context for this change. I have one suggestion to improve the TODO comment for better long-term tracking.
|
|
||
| frequency: nightly | ||
| # Ray Train V2 doesn't support colocation. | ||
| # TODO: Decide whether to remove this test or re-enable it if we add support again. |
Contributor
There was a problem hiding this comment.
For better traceability, it's good practice to link TODO comments to their corresponding issue numbers. This will help future developers quickly understand the context and history of this change.
# TODO(#49454): Decide whether to remove this test or re-enable it if we add support again.
JasonLi1909
approved these changes
Oct 21, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
## Description Change `train_colocate_trainer` release test frequency to be manual. ## Related issues Related to #49454. ## Additional information `ScalingConfig.trainer_resources` has been deprecated in Ray Train V2. As a result, we should disable the test for now. In the future, we can either: 1. Delete this test entirely. 2. Add back functionality for colocation & reenable this test. Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
## Description Change `train_colocate_trainer` release test frequency to be manual. ## Related issues Related to ray-project#49454. ## Additional information `ScalingConfig.trainer_resources` has been deprecated in Ray Train V2. As a result, we should disable the test for now. In the future, we can either: 1. Delete this test entirely. 2. Add back functionality for colocation & reenable this test. Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
## Description Change `train_colocate_trainer` release test frequency to be manual. ## Related issues Related to ray-project#49454. ## Additional information `ScalingConfig.trainer_resources` has been deprecated in Ray Train V2. As a result, we should disable the test for now. In the future, we can either: 1. Delete this test entirely. 2. Add back functionality for colocation & reenable this test. Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
train_colocate_trainerrelease test frequency to be manual.Related issues
Related to #49454.
Additional information
ScalingConfig.trainer_resourceshas been deprecated in Ray Train V2. As a result, we should disable the test for now. In the future, we can either: