[bugfix][data][llm] Fix vLLMEngineStage field name inconsistency for images #57980
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ray-project#57978 - Fixed get_optional_input_keys() to declare 'image' (singular) instead of 'images' - Added clear error message and fix when users provide 'images' field in the custom path (`has_image = False`) Signed-off-by: Nikhil Ghosh <nikhil@anyscale.com>
| # Extract image data from preprocessing output | ||
| if "image" in row: | ||
| image = row.pop("image") | ||
| elif "images" in row: |
Contributor
There was a problem hiding this comment.
this is weird, I am inclined to not throw any errors and dump it on the user to do it right.
Contributor
Author
There was a problem hiding this comment.
I agree - calling it deprecated is also not quite right. Can just keep behavior as it was before, and include just the doc fix for clarification (so at least internally, we are consistent)?
Contributor
There was a problem hiding this comment.
yeah let's keep the old one.
| return { | ||
| "tokenized_prompt": "The tokenized prompt. If provided, the prompt will not be tokenized by the vLLM engine.", | ||
| "images": "The images to generate text from. If provided, the prompt will be a multimodal prompt.", | ||
| "image": "The image(s) for multimodal input. Accepts a single image or list of images.", |
Signed-off-by: Nikhil Ghosh <nikhil@anyscale.com>
kouroshHakha
approved these changes
Oct 22, 2025
kouroshHakha
changed the title
|
Thank you @nrghosh for helping to integrate |
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…ay-project#57980) Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57978
has_image = False)