[ci] write test progress message to stderr #58019
Conversation
otherwise, the ordering or messages looks strange on windows. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
|
testing with windows core test: https://buildkite.com/ray-project/postmerge/builds/13952 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a message ordering issue on Windows CI builds by redirecting progress messages to stderr. The changes are straightforward and effective. I have one suggestion regarding the repeated use of print(..., file=sys.stderr) for these CI messages. To improve maintainability, it would be beneficial to abstract this into a dedicated helper function. This would make the code cleaner and the intent of these special print statements more explicit.
| print("--- No tests to run", file=sys.stderr) | ||
| sys.exit(0) | ||
|
|
||
| print(f"+++ Running {len(test_targets)} tests") | ||
| print(f"+++ Running {len(test_targets)} tests", file=sys.stderr) |
There was a problem hiding this comment.
These changes correctly redirect CI progress messages to stderr. Since this pattern is now used on line 260 as well, consider abstracting it into a helper function to improve maintainability and clarify that these are special CI-related outputs. For example:
def _log_ci_status(message: str) -> None:
"""Prints a status message to stderr for CI visibility."""
print(message, file=sys.stderr)This would centralize the logic and make the code easier to read and maintain.
otherwise, the ordering or messages looks strange on windows. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: xgui <xgui@anyscale.com>
otherwise, the ordering or messages looks strange on windows. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
otherwise, the ordering or messages looks strange on windows. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
otherwise, the ordering or messages looks strange on windows.