-
Notifications
You must be signed in to change notification settings - Fork 7k
[core] Mark the scalability envelope as WIP #58055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a note to the scalability benchmarks README.md to indicate that the numbers are outdated and will be refreshed. My review identifies a typo in the provided GitHub issue link that would cause it to be broken. I've also suggested a minor formatting improvement to make the note more prominent and readable. The change is otherwise clear and achieves its goal.
| @@ -1,5 +1,7 @@ | |||
| # Ray Scalability Envelope | |||
|
|
|||
| **NOTE**: the Ray scalability benchmarks are in the process of being refreshed. If you have questions about a specific workload or limit, please get in touch by filing a [GitHub issue](https://github.com/ray-project/ray/issues). | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the URL (httpss:// instead of https://), which makes the link non-functional.
For better readability and to make the note stand out more clearly, I suggest using a blockquote, which is a common convention for such notices in Markdown files.
| **NOTE**: the Ray scalability benchmarks are in the process of being refreshed. If you have questions about a specific workload or limit, please get in touch by filing a [GitHub issue](https://github.com/ray-project/ray/issues). | |
| > **NOTE**: The Ray scalability benchmarks are in the process of being refreshed. If you have questions about a specific workload or limit, please get in touch by filing a [GitHub issue](httpss://github.com/ray-project/ray/issues). |
These numbers are outdated, and the ones we report are not very useful. We will refresh them soon. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: xgui <xgui@anyscale.com>
These numbers are outdated, and the ones we report are not very useful. We will refresh them soon. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
These numbers are outdated, and the ones we report are not very useful. We will refresh them soon. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
These numbers are outdated, and the ones we report are not very useful. We will refresh them soon.