Skip to content

Conversation

@edoakes
Copy link
Collaborator

@edoakes edoakes commented Oct 23, 2025

These numbers are outdated, and the ones we report are not very useful. We will refresh them soon.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Oct 23, 2025
@edoakes edoakes requested a review from a team October 23, 2025 18:59
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a note to the scalability benchmarks README.md to indicate that the numbers are outdated and will be refreshed. My review identifies a typo in the provided GitHub issue link that would cause it to be broken. I've also suggested a minor formatting improvement to make the note more prominent and readable. The change is otherwise clear and achieves its goal.

@@ -1,5 +1,7 @@
# Ray Scalability Envelope

**NOTE**: the Ray scalability benchmarks are in the process of being refreshed. If you have questions about a specific workload or limit, please get in touch by filing a [GitHub issue](https://github.com/ray-project/ray/issues).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There's a typo in the URL (httpss:// instead of https://), which makes the link non-functional.

For better readability and to make the note stand out more clearly, I suggest using a blockquote, which is a common convention for such notices in Markdown files.

Suggested change
**NOTE**: the Ray scalability benchmarks are in the process of being refreshed. If you have questions about a specific workload or limit, please get in touch by filing a [GitHub issue](https://github.com/ray-project/ray/issues).
> **NOTE**: The Ray scalability benchmarks are in the process of being refreshed. If you have questions about a specific workload or limit, please get in touch by filing a [GitHub issue](httpss://github.com/ray-project/ray/issues).

@ray-gardener ray-gardener bot added docs An issue or change related to documentation core Issues that should be addressed in Ray Core labels Oct 23, 2025
@edoakes edoakes enabled auto-merge (squash) October 23, 2025 19:02
@edoakes edoakes merged commit 4f497a6 into ray-project:master Oct 23, 2025
5 of 6 checks passed
xinyuangui2 pushed a commit to xinyuangui2/ray that referenced this pull request Oct 27, 2025
These numbers are outdated, and the ones we report are not very useful.
We will refresh them soon.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: xgui <xgui@anyscale.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
These numbers are outdated, and the ones we report are not very useful.
We will refresh them soon.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
These numbers are outdated, and the ones we report are not very useful.
We will refresh them soon.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core docs An issue or change related to documentation go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants