-
Notifications
You must be signed in to change notification settings - Fork 7k
[llm][data] Change example pip install to ray[llm] #58096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llm][data] Change example pip install to ray[llm] #58096
Conversation
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the installation instructions in two example notebooks to use ray[llm], which is a good step for consistency. The change for vllm-with-lora.ipynb looks correct. However, for vllm-with-structural-output.ipynb, the xgrammar dependency was removed. Since ray[llm] does not appear to install xgrammar, this could break the notebook for users. I've added a comment with a suggestion to re-introduce xgrammar to the installation command for that specific notebook.
Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: xgui <xgui@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
Description
Additional information
Manual tests complete successfully with


rayproject/ray-llm:2.50.1-py311-cu128: