[Data] - Add human friendly repr for Expression Tree #58154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Goutam <goutam@anyscale.com>
goutamvenkat-anyscale
added
data
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a human-friendly tree representation for Expression objects by implementing a __repr__ method. The implementation uses a _TreeReprVisitor to recursively build the string representation. The changes are well-tested. My feedback focuses on improving the readability of the generated tree and enhancing code maintainability by removing redundant code and magic numbers.
python/ray/data/_internal/planner/plan_expression/expression_visitors.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/planner/plan_expression/expression_visitors.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/planner/plan_expression/expression_visitors.py
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Goutam <goutam@anyscale.com>
alexeykudinkin
approved these changes
Oct 25, 2025
| udf_expr.to_pyarrow() | ||
|
|
||
|
|
||
| class TestExpressionRepr: |
Contributor
There was a problem hiding this comment.
Please trim this to a single most complicated test
Signed-off-by: Goutam <goutam@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
## Description
As title states.
Example:
```
from ray.data.expressions import col, lit
expr = (col("x") + lit(5)) * col("y")
print(expr)
MUL
├── left: ADD
│ ├── left: COL('x')
│ └── right: LIT(5)
└── right: COL('y')
```
## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".
## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.
---------
Signed-off-by: Goutam <goutam@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
## Description
As title states.
Example:
```
from ray.data.expressions import col, lit
expr = (col("x") + lit(5)) * col("y")
print(expr)
MUL
├── left: ADD
│ ├── left: COL('x')
│ └── right: LIT(5)
└── right: COL('y')
```
## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".
## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.
---------
Signed-off-by: Goutam <goutam@anyscale.com>
Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title states.
Example:
Related issues
Additional information