[core][cherry-pick] RDT NIXL Limitations + Throw Exception #58159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhyey Shah <dhyey2019@gmail.com> Signed-off-by: Qiaolin-Yu <liin1211@outlook.com> Signed-off-by: Qiaolin Yu <liin1211@outlook.com> Co-authored-by: Dhyey Shah <dhyey2019@gmail.com> Co-authored-by: Stephanie Wang <smwang@cs.washington.edu>
dayshah
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if tensor in self._tensor_to_object_ids: | ||
| raise ValueError( | ||
| f"Tensor already exists in the RDT object store. Free all references to ObjectRef({obj_id}) before storing the tensor again." | ||
| ) |
There was a problem hiding this comment.
Bug: Misleading Error Message in Object Addition
The error message in add_object() refers to the new obj_id being added, but should reference the existing object IDs that already own the tensor. When a tensor already exists in the store, the user needs to free the OLD object ID that contains the tensor, not the NEW obj_id being added. The error message is misleading and provides incorrect guidance to the user about which ObjectRef to free.
aslonnie
approved these changes
Oct 25, 2025
weiquanlee
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Dec 11, 2025
…ct#58159) ## Description Cherry-picking ray-project#58063 to throw an exception when trying to double send the same ref before gc because it can trigger a NIXL error. Also adding documentation for this. Signed-off-by: Dhyey Shah <dhyey2019@gmail.com> Signed-off-by: Qiaolin-Yu <liin1211@outlook.com> Signed-off-by: Qiaolin Yu <liin1211@outlook.com> Co-authored-by: Qiaolin Yu <liin1211@outlook.com> Co-authored-by: Stephanie Wang <smwang@cs.washington.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picking #58063 to throw an exception when trying to double send the same ref before gc because it can trigger a NIXL error. Also adding documentation for this.