Skip to content

Conversation

@aslonnie
Copy link
Collaborator

Reverts #58036

@aslonnie aslonnie merged commit 4c82e82 into master Oct 25, 2025
2 of 5 checks passed
@aslonnie aslonnie deleted the revert-58036-elliot-barn/update-ci-py310-subset branch October 25, 2025 04:29
@aslonnie
Copy link
Collaborator Author

@elliot-barn

PYTHON_VERSION: "{{matrix.python}}"
EXTRA_DEPENDENCY: "{{matrix.app}}"
PYTHON_VERSION: "3.9"
EXTRA_DEPENDENCY: "{{matrix}}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Python Version Mismatch in Build Names

The label template "wanda: minbuild-{{matrix}}-py39" will generate build names like minbuild-default-py39 and minbuild-serve-py39 (without a dot between 3 and 9), but the build-name references in the commands at lines 151 and 164 use minbuild-default-py3.9 and minbuild-serve-py3.9 (with a dot). This naming mismatch will cause test steps to fail when they cannot find the referenced build artifacts. The label template should use py{{matrix}}.9 instead of py39 to generate the correct build names, or the build-name references should be changed to match the new template format (without the dot).

Fix in Cursor Fix in Web

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous change that enabled Python 3.10 for a subset of CI tests. The changes correctly remove Python 3.10 from various test matrices and CI configurations across multiple .buildkite YAML files. Hardcoded versions and dependencies are consistently reverted from 3.10 to 3.9. The modifications appear correct and align with the goal of the revert.

xinyuangui2 pushed a commit to xinyuangui2/ray that referenced this pull request Oct 27, 2025
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants