Fix typos #58349
Fix typos #58349
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes several typos across the codebase. The changes are correct and improve code quality. I've added one comment regarding an incorrect function signature and docstring in python/ray/dashboard/modules/reporter/profile_manager.py that should be addressed.
| Tuple[bool, str]: A tuple containing a boolean indicating the success | ||
| of the operation and a string of a sucess message or an error message. | ||
| of the operation and a string of a success message or an error message. |
There was a problem hiding this comment.
The type hint in the docstring for attach_profiler is Tuple[bool, str], but the implementation returns a 3-element tuple: (bool, Optional[str], str). This is misleading and can cause issues for developers using this function.
The docstring and the function's type hint should be updated to reflect the actual return type. Please also update the function signature on line 274 from -> (bool, str) to -> Tuple[bool, Optional[str], str] and add the necessary imports from typing (Tuple, Optional).
| Tuple[bool, str]: A tuple containing a boolean indicating the success | |
| of the operation and a string of a sucess message or an error message. | |
| of the operation and a string of a success message or an error message. | |
| Tuple[bool, Optional[str], str]: A tuple containing a boolean indicating the | |
| success of the operation, the profiler filename if successful, and a string with a success or an error message. |
ray-gardener
bot
added
docs
Fix typos Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Fix typos Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Fix typos Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Fix typos Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
4 participants
Description
Fix typos