-
Notifications
You must be signed in to change notification settings - Fork 7k
[Data] Update image_embedding_from_jsonl release to read from us-west-2
#58437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the S3 bucket for the image_embedding_from_jsonl nightly test to a region-specific bucket (us-west-2). This is a good change as it aligns the data source region with the compute region specified in the cluster configuration, which should improve performance and reduce costs. My only suggestion is to consider making the input S3 path configurable to improve the test's flexibility. Overall, the change is correct and beneficial.
image_embedding_from_jsonl release to read from us-west-2
…st-2 (ray-project#58437) ## Description The `image_embedding_from_jsonl` release tests are typically run in us-west-2, but they read data from a bucket in a different region. This is problematic because it's expensive and unrealistic (users often read data in the same region), and has a noticeable impact on read speeds. To address this issue, this PR updates the release test to read from a bucket in us-west-2. ## Related issues Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
…st-2 (ray-project#58437) ## Description The `image_embedding_from_jsonl` release tests are typically run in us-west-2, but they read data from a bucket in a different region. This is problematic because it's expensive and unrealistic (users often read data in the same region), and has a noticeable impact on read speeds. To address this issue, this PR updates the release test to read from a bucket in us-west-2. ## Related issues Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
…st-2 (ray-project#58437) ## Description The `image_embedding_from_jsonl` release tests are typically run in us-west-2, but they read data from a bucket in a different region. This is problematic because it's expensive and unrealistic (users often read data in the same region), and has a noticeable impact on read speeds. To address this issue, this PR updates the release test to read from a bucket in us-west-2. ## Related issues Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Description
The
image_embedding_from_jsonlrelease tests are typically run in us-west-2, but they read data from a bucket in a different region. This is problematic because it's expensive and unrealistic (users often read data in the same region), and has a noticeable impact on read speeds.To address this issue, this PR updates the release test to read from a bucket in us-west-2.
Related issues