Skip to content

Conversation

@bveeramani
Copy link
Member

@bveeramani bveeramani commented Nov 6, 2025

Description

The image_embedding_from_jsonl release tests are typically run in us-west-2, but they read data from a bucket in a different region. This is problematic because it's expensive and unrealistic (users often read data in the same region), and has a noticeable impact on read speeds.

To address this issue, this PR updates the release test to read from a bucket in us-west-2.

Related issues

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani bveeramani marked this pull request as draft November 6, 2025 21:32
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the S3 bucket for the image_embedding_from_jsonl nightly test to a region-specific bucket (us-west-2). This is a good change as it aligns the data source region with the compute region specified in the cluster configuration, which should improve performance and reduce costs. My only suggestion is to consider making the input S3 path configurable to improve the test's flexibility. Overall, the change is correct and beneficial.

@bveeramani bveeramani changed the title [DNR] [Data] Update image_embedding_from_jsonl release to read from us-west-2 Nov 16, 2025
@bveeramani bveeramani marked this pull request as ready for review November 16, 2025 02:22
@bveeramani bveeramani enabled auto-merge (squash) November 16, 2025 02:22
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Nov 16, 2025
@ray-gardener ray-gardener bot added data Ray Data-related issues release-test release test labels Nov 16, 2025
@github-actions github-actions bot disabled auto-merge November 16, 2025 20:49
@bveeramani bveeramani merged commit de5f370 into master Nov 17, 2025
6 checks passed
@bveeramani bveeramani deleted the image-embedding-us-west-2 branch November 17, 2025 05:31
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
…st-2 (ray-project#58437)

## Description

The `image_embedding_from_jsonl` release tests are typically run in
us-west-2, but they read data from a bucket in a different region. This
is problematic because it's expensive and unrealistic (users often read
data in the same region), and has a noticeable impact on read speeds.

To address this issue, this PR updates the release test to read from a
bucket in us-west-2.
## Related issues

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Aydin Abiar <aydin@anyscale.com>
ykdojo pushed a commit to ykdojo/ray that referenced this pull request Nov 27, 2025
…st-2 (ray-project#58437)

## Description

The `image_embedding_from_jsonl` release tests are typically run in
us-west-2, but they read data from a bucket in a different region. This
is problematic because it's expensive and unrealistic (users often read
data in the same region), and has a noticeable impact on read speeds.

To address this issue, this PR updates the release test to read from a
bucket in us-west-2.
## Related issues

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
…st-2 (ray-project#58437)

## Description

The `image_embedding_from_jsonl` release tests are typically run in
us-west-2, but they read data from a bucket in a different region. This
is problematic because it's expensive and unrealistic (users often read
data in the same region), and has a noticeable impact on read speeds.

To address this issue, this PR updates the release test to read from a
bucket in us-west-2.
## Related issues

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Ray Data-related issues go add ONLY when ready to merge, run all tests release-test release test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants