[core] Fixes static type hints for ActorClass when setting options through ray.remote #58439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolitaryThinker
force-pushed
the
will/fix_remote_options_typing
branch
from
787887b to
6d2c5aa
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the issue of incorrect static type hints for ActorClass when using ray.remote. The added overloads in python/ray/_private/worker.py correctly type hint ray.remote(Actor) and ray.remote(**options)(Actor) to return a generic ActorClass[T], which is a great improvement for static analysis. The reordering of @overload decorators for ray.method in python/ray/actor.py also appears to be a good change to handle methods with default arguments more robustly. The changes are clean and well-targeted. One minor point is that a comment in python/ray/_private/worker.py (lines 3465-3466 on the right side of the diff) is now outdated due to the typing improvements in this PR, and could be removed to avoid confusion.
Signed-off-by: will.lin <will.lin@anyscale.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: will.lin <will.lin@anyscale.com>
edoakes
approved these changes
Nov 7, 2025
YoussefEssDS
pushed a commit
to YoussefEssDS/ray
that referenced
this pull request
Nov 8, 2025
…rough ray.remote (ray-project#58439) Fixes static type hints for ActorClass when setting options through ray.remote Closes ray-project#58401 and ray-project#58402 cc @richardliaw @edoakes @pcmoritz --------- Signed-off-by: will.lin <will.lin@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…rough ray.remote (ray-project#58439) Fixes static type hints for ActorClass when setting options through ray.remote Closes ray-project#58401 and ray-project#58402 cc @richardliaw @edoakes @pcmoritz --------- Signed-off-by: will.lin <will.lin@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…rough ray.remote (ray-project#58439) Fixes static type hints for ActorClass when setting options through ray.remote Closes ray-project#58401 and ray-project#58402 cc @richardliaw @edoakes @pcmoritz --------- Signed-off-by: will.lin <will.lin@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
…rough ray.remote (ray-project#58439) Fixes static type hints for ActorClass when setting options through ray.remote Closes ray-project#58401 and ray-project#58402 cc @richardliaw @edoakes @pcmoritz --------- Signed-off-by: will.lin <will.lin@anyscale.com> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
…rough ray.remote (ray-project#58439) Fixes static type hints for ActorClass when setting options through ray.remote Closes ray-project#58401 and ray-project#58402 cc @richardliaw @edoakes @pcmoritz --------- Signed-off-by: will.lin <will.lin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…rough ray.remote (ray-project#58439) Fixes static type hints for ActorClass when setting options through ray.remote Closes ray-project#58401 and ray-project#58402 cc @richardliaw @edoakes @pcmoritz --------- Signed-off-by: will.lin <will.lin@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes static type hints for ActorClass when setting options through ray.remote
Currently:
After this PR:
Related issues
Closes #58401 and #58402
cc @richardliaw @edoakes @pcmoritz
Additional information