Skip to content

[core] Improve kill actor logs #58544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

[core] Improve kill actor logs #58544

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0214d3
[core] Improve kill actor logs
dayshah Nov 11, 2025
f7f4aa8
typo
dayshah Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/ray/gcs/gcs_actor_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1755,7 +1755,9 @@ void GcsActorManager::NotifyRayletToKillActor(const std::shared_ptr<GcsActor> &a
request.mutable_death_cause()->CopyFrom(death_cause);
request.set_force_kill(force_kill);
if (!actor->LocalRayletAddress()) {
RAY_LOG(DEBUG) << "Actor " << actor->GetActorID() << " has not been assigned a lease";
RAY_LOG(INFO).WithField(actor->GetActorID())
<< "Not sending KillLocalActorRequest because Actor has not been assigned a "
"lease";
return;
}
auto actor_raylet_client =
Expand All @@ -1767,13 +1769,13 @@ void GcsActorManager::NotifyRayletToKillActor(const std::shared_ptr<GcsActor> &a
<< "Send request to kill actor to worker at node";
actor_raylet_client->KillLocalActor(
request,
[actor_id = actor->GetActorID()](const ray::Status &status,
rpc::KillLocalActorReply &&reply) {
[node_id = actor->GetNodeID(), actor_id = actor->GetActorID()](
const ray::Status &status, rpc::KillLocalActorReply &&reply) {
if (!status.ok()) {
RAY_LOG(ERROR) << "Failed to kill actor " << actor_id
<< ", return status: " << status.ToString();
RAY_LOG(INFO).WithField(actor_id).WithField(node_id)
<< "Node with actor is already dead, return status: " << status.ToString();
} else {
RAY_LOG(INFO) << "Killed actor " << actor_id << " successfully.";
RAY_LOG(INFO).WithField(actor_id) << "Killed actor successfully.";
}
});
}
Expand Down