[ci] install uv python in forge without project #58663
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the forge.Dockerfile to install Python using uv without creating project configuration files. This is achieved by adding the --no-project flag to uv python find and removing the uv python pin command. The changes also introduce a UV_PYTHON_VERSION variable for better maintainability and improve shell command robustness by quoting variables.
My review includes a suggestion to make the symlink creation more robust by using the -f flag, which will prevent errors if the script is run in an environment where the symlinks already exist.
| ln -s "$UV_PYTHON_BIN" "/usr/local/bin/python${UV_PYTHON_VERSION}" | ||
| ln -s "$UV_PYTHON_BIN" /usr/local/bin/python3 | ||
| ln -s "$UV_PYTHON_BIN" /usr/local/bin/python |
There was a problem hiding this comment.
To make the script more robust and idempotent, consider using the -f (force) flag with ln. This will ensure that if the symlinks already exist, they are overwritten without causing an error. This is particularly useful if this part of the script is re-executed.
ln -sf "$UV_PYTHON_BIN" "/usr/local/bin/python${UV_PYTHON_VERSION}"
ln -sf "$UV_PYTHON_BIN" /usr/local/bin/python3
ln -sf "$UV_PYTHON_BIN" /usr/local/bin/python
so that it does not need / create project config files we just need the self-contained binary Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
force-pushed
the
lonnie-251115-forgenoproj
branch
from
9c8127c to
06f5e87
Compare
so that it does not need / create project config files we just need the self-contained binary Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Justin Miller <justinrmiller@gmail.com>
so that it does not need / create project config files we just need the self-contained binary Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: ryankert01 <ryan980053@gmail.com>
so that it does not need / create project config files we just need the self-contained binary Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
so that it does not need / create project config files we just need the self-contained binary Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
so that it does not need / create project config files we just need the self-contained binary Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
so that it does not need / create project config files
we just need the self-contained binary