[release test] edit shell script styling in run_release_test.sh #58670
Conversation
use double brackets as much as possible Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| reason() { | ||
| # Keep in sync with e2e.py ExitCode enum | ||
| if [ "$1" -eq 0 ]; then | ||
| if [[ "$1" -eq 0 ]]; then |
There was a problem hiding this comment.
Bug: Debugging Output Feature Unexpectedly Removed
The DEBUG environment variable check and set -x functionality was removed, eliminating the ability to enable verbose shell debugging output. This appears unintentional since the PR only aims to standardize bracket usage, not remove features.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request correctly updates the shell script to use [[ ... ]] instead of [ ... ], which is a good practice for bash scripts. However, I've identified two issues. A block of code for enabling debug mode appears to have been unintentionally removed. Additionally, the reason function has a bug that could lead to incorrect error reporting for unhandled exit codes. I've provided detailed comments and suggestions for both of these points.
ray-gardener
bot
added
core
…project#58670) use double brackets as much as possible Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
…project#58670) use double brackets as much as possible Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
…project#58670) use double brackets as much as possible Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
…project#58670) use double brackets as much as possible Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
use double brackets as much as possible