[CI] Add kafka-python&testcontainers[kafka] to deps
#58680
Conversation
owenowenisme
added
data
|
cc @aslonnie |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds kafka-python and testcontainers[kafka] as dependencies for testing purposes. The changes are mostly updates to dependency lock files, which is expected. I've found a critical issue in python/requirements_compiled.txt where the version constraint for grpcio seems to have been incorrectly changed, which could break builds for Python 3.10+. Additionally, the new dependencies in python/requirements/ml/data-test-requirements.txt are not version-pinned, which is not ideal for reproducible builds. Please see my comments for details.
Signed-off-by: You-Cheng Lin (Owen) <mses010108@gmail.com>
owenowenisme
force-pushed
the
ci/add-data-test-deps
branch
from
1425b03 to
461037f
Compare
|
@aslonnie Test is failing but I don't think that is related to my change |
synced master; it is fixed there. |
…58680) for implementing kafka datasource. Signed-off-by: You-Cheng Lin (Owen) <mses010108@gmail.com> Co-authored-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
…58680) for implementing kafka datasource. Signed-off-by: You-Cheng Lin (Owen) <mses010108@gmail.com> Co-authored-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
…58680) for implementing kafka datasource. Signed-off-by: You-Cheng Lin (Owen) <mses010108@gmail.com> Co-authored-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
2 participants
Description
For #58592
Related issues
Additional information