[spark] Fix RuntimeError in SparkJobServer.shutdown() during dict iteration #58888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration Signed-off-by: Cai Zhanqi <zhanqi.cai@shopee.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a RuntimeError: dictionary changed size during iteration in SparkJobServer.shutdown(). The error occurs because task_status_dict is iterated over while potentially being modified by background threads. The fix correctly resolves this race condition by creating a copy of the dictionary's keys before iteration using list(self.task_status_dict.keys()). This is a standard and effective way to prevent such errors. The change is simple, targeted, and correct. Good job!
ray-gardener
bot
added
data
edoakes
approved these changes
Nov 21, 2025
Collaborator
|
Thanks @CaiZhanqi! |
Collaborator
|
I've triggered premerge CI tests and the PR will auto-merge if they pass. If not, please ping me. |
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Nov 21, 2025
…ration (ray-project#58888) ## Description > Fixed "dictionary changed size during iteration" error that occurs when shutdown() iterates over task_status_dict while background threads modify it concurrently. ## Additional information > Why not use thread lock? The bug is in the shutdown part, and no other parts iterate it. Signed-off-by: Cai Zhanqi <zhanqi.cai@shopee.com> Co-authored-by: Cai Zhanqi <zhanqi.cai@shopee.com>
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
…ration (ray-project#58888) ## Description > Fixed "dictionary changed size during iteration" error that occurs when shutdown() iterates over task_status_dict while background threads modify it concurrently. ## Additional information > Why not use thread lock? The bug is in the shutdown part, and no other parts iterate it. Signed-off-by: Cai Zhanqi <zhanqi.cai@shopee.com> Co-authored-by: Cai Zhanqi <zhanqi.cai@shopee.com> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
…ration (ray-project#58888) ## Description > Fixed "dictionary changed size during iteration" error that occurs when shutdown() iterates over task_status_dict while background threads modify it concurrently. ## Additional information > Why not use thread lock? The bug is in the shutdown part, and no other parts iterate it. Signed-off-by: Cai Zhanqi <zhanqi.cai@shopee.com> Co-authored-by: Cai Zhanqi <zhanqi.cai@shopee.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional information