Skip to content

Conversation

@pseudo-rnd-thoughts
Copy link
Member

Description

RLlib is divided on its testing structure, we have the /tests folder and for components <component>/tests folder mixing the two testing project structures.
This PR commits to the component style of project structure moving tests/ files to their component folder.

Related issues

General project structure improvements

Signed-off-by: Mark Towers <mark@anyscale.com>
@pseudo-rnd-thoughts pseudo-rnd-thoughts requested a review from a team as a code owner November 21, 2025 12:20
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the testing structure by moving test files into component-specific folders, which is a great step towards better project organization. The changes mostly consist of path updates to reflect the new structure. I've found a couple of incorrect path updates that could lead to failures and should be addressed.

Signed-off-by: Mark Towers <mark@anyscale.com>
@ray-gardener ray-gardener bot added the rllib RLlib related issues label Nov 21, 2025
Mark Towers added 4 commits November 21, 2025 14:01
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
@pseudo-rnd-thoughts pseudo-rnd-thoughts added the go add ONLY when ready to merge, run all tests label Nov 21, 2025
Mark Towers added 3 commits November 23, 2025 13:36
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Copy link
Contributor

@kamil-kaczmarek kamil-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kamil-kaczmarek kamil-kaczmarek changed the title [rllib] Clean up tests folder, in favor of /component/tests [RLlib] Clean up tests folder, in favor of /component/tests Nov 25, 2025
@ArturNiederfahrenhorst ArturNiederfahrenhorst merged commit ed14974 into ray-project:master Nov 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests rllib RLlib related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants