-
Notifications
You must be signed in to change notification settings - Fork 7k
[RLlib] Clean up tests folder, in favor of /component/tests #58890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Clean up tests folder, in favor of /component/tests #58890
Conversation
Signed-off-by: Mark Towers <mark@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the testing structure by moving test files into component-specific folders, which is a great step towards better project organization. The changes mostly consist of path updates to reflect the new structure. I've found a couple of incorrect path updates that could lead to failures and should be addressed.
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
kamil-kaczmarek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
RLlib is divided on its testing structure, we have the
/testsfolder and for components<component>/testsfolder mixing the two testing project structures.This PR commits to the component style of project structure moving
tests/files to their component folder.Related issues
General project structure improvements