Skip to content

Conversation

@aslonnie
Copy link
Collaborator

and performing some styling cleanup

and performing some styling cleanup

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
@aslonnie aslonnie requested a review from a team November 23, 2025 01:17
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Nov 23, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a nice cleanup of the main CI script ci/ci.sh. The removal of the suppress_xtrace, reload_env, and _main functions correctly eliminates obsolete code that was part of a compatibility layer for running Travis CI scripts on GitHub Actions. This simplification makes the script easier to understand and maintain. The styling cleanups are also a welcome improvement, consistently replacing the old [ ... ] test command with the more modern and robust [[ ... ]] keyword for string comparisons. The changes are correct and well-contained. Overall, this is a good improvement to the CI infrastructure.

@aslonnie aslonnie merged commit 3c649a2 into master Nov 26, 2025
6 checks passed
@aslonnie aslonnie deleted the lonnie-251122-norefreshenv branch November 26, 2025 07:04
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
and performing some styling cleanup

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devprod go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants