Skip to content

[core] Removing unused boilerplate grpc benchmarks #58955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2025
Merged

[core] Removing unused boilerplate grpc benchmarks #58955

merged 1 commit into from
Nov 25, 2025
+0 −242

Conversation

@israbbani
Copy link
Contributor

@israbbani israbbani commented Nov 24, 2025

While adding benchmarks is generally a good thing, this suite leaves a few things to be desired

  1. It has not be run since 2022.
  2. The instructions to run them manually do not tell you how to run them.

I think we should delete these and re-add appropriate benchmarks.

@israbbani
[core] Removing unused boilerplate grpc benchmarks
793a993 
Signed-off-by: irabbani <irabbani@anyscale.com>
@israbbani israbbani added the go add ONLY when ready to merge, run all tests label Nov 24, 2025
@israbbani israbbani marked this pull request as ready for review November 24, 2025 23:58
@israbbani israbbani requested a review from a team as a code owner November 24, 2025 23:58
dayshah
dayshah approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@dayshah dayshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪦

@dayshah dayshah enabled auto-merge (squash) November 25, 2025 00:11
@dayshah dayshah merged commit a4e647a into master Nov 25, 2025
6 of 7 checks passed
@dayshah dayshah deleted the irabbani/deleting-unused-code-2 branch November 25, 2025 00:59
ykdojo pushed a commit to ykdojo/ray that referenced this pull request Nov 27, 2025
@israbbani @ykdojo
[core] Removing unused boilerplate grpc benchmarks (ray-project#58955)
9f0f364 
Signed-off-by: irabbani <irabbani@anyscale.com>
Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
@israbbani @SheldonTsen
[core] Removing unused boilerplate grpc benchmarks (ray-project#58955)
bc29848 
Signed-off-by: irabbani <irabbani@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dayshah dayshah dayshah approved these changes

Assignees

No one assigned

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@israbbani @dayshah